D13594: Split SMS and Telephony plugin on desktop

[Simon Redman]

sredman accepted this revision as: sredman.
sredman added a comment.
This revision is now accepted and ready to land.


  This has been working for me for a couple of weeks, so I think we're good. The tiny change I just pushed - to check the Telepathy interface before calling it - avoids an error and doesn't change any functionality (since it didn't work before anyway!)

INLINE COMMENTS

> kdeconnect_sms.json:11
> +        "EnabledByDefault": true,
> +        "Icon": "dialog-ok",
> +        "Id": "kdeconnect_sms",

Also perhaps we should find a new icon for this. How do I look at the list of available icons?

REPOSITORY
  R224 KDE Connect

BRANCH
  sms-split

REVISION DETAIL
  https://phabricator.kde.org/D13594

To: nicolasfella, #kde_connect, sredman
Cc: albertvaka, apol, sredman, kdeconnect, #kde_connect, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, marcorichetta, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180908/10ea9362/attachment-0001.html>