<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Johnny,</p>
<p>I left some comments in the review.</p>
<p>To reduce the number of plugins just extend the blacklist. But Id
rather recommend to ship to many files than to few.</p>
<p>Cheers,</p>
<p>Hannah<br>
</p>
<div class="moz-cite-prefix">On 07/09/2020 15:17, Johnny Jazeix
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAEtcAPGS=fCvRdZYAr3ORGVN-yKF2wOtTJz+XJWbZtiam6toFA@mail.gmail.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div>Hi,</div>
<div><br>
</div>
<div>pinging again for the issues as I didn't managed to solve
them yet.</div>
<div><br>
</div>
<div>Thank you,</div>
<div><br>
</div>
<div>Johnny<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">Le dim. 2 août 2020 à 22:03,
Johnny Jazeix <<a href="mailto:jazeix@gmail.com"
moz-do-not-send="true">jazeix@gmail.com</a>> a écrit :<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div>Hi,</div>
<div><br>
</div>
<div>I'm trying to craft Marble and I have some issues:</div>
<div>* Marble creates plugins that are installed to plugins/
folder. Due to <a
href="https://invent.kde.org/packaging/craft/-/blob/master/bin/Packager/CollectionPackagerBase.py#L304"
target="_blank" moz-do-not-send="true">https://invent.kde.org/packaging/craft/-/blob/master/bin/Packager/CollectionPackagerBase.py#L304</a>
(which is used for Qt plugins), they are moved to bin/. Is
there a way to make a more selective choice to only move
Qt plugins?</div>
<div><br>
</div>
<div>* I created the package (see <a
href="https://invent.kde.org/packaging/craft-blueprints-kde/-/merge_requests/20/diffs"
target="_blank" moz-do-not-send="true">https://invent.kde.org/packaging/craft-blueprints-kde/-/merge_requests/20/diffs</a>
for the recipe) and there are a lot of unwanted files:
mysql, msg*.exe, other executables... in
C:\CraftRoot\build\kde\applications\marble\archive\bin
that are shipped. Do you have an idea on where they come
from and how to ignore them?</div>
<div>Blacklisting with
"bin\\(?!(msg*|test*|r*|mysql*)).*\.exe" does not work.<br>
</div>
<div><br>
</div>
<div>* This is less important but when I "ctrl+C" craft, it
still says I succeeded ;).</div>
<div><br>
</div>
<div>I can also create bugs on bugs.kde if needed.</div>
<div><br>
</div>
<div>Thank you,</div>
<div><br>
</div>
<div>Johnny</div>
<div><br>
</div>
</div>
</blockquote>
</div>
</blockquote>
</body>
</html>