<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127288/">https://git.reviewboard.kde.org/r/127288/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also see https://github.com/KDE/emerge/blob/master/portage/extragear/kdevelop/kdevelop.py#L79 for a fixup during packaging time in emerge.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I knew -DKDE_INSTALL_USE_QT_SYS_PATHS=TRUE before, but we didn't bother enough to set this by default in emerge now. Also, https://git.reviewboard.kde.org/r/127169/ indeed seems to be the saner approach.</p></pre>
<br />
<p>- Kevin Funk</p>
<br />
<p>On March 5th, 2016, 4:36 p.m. UTC, Thomas Friedrichsmeier wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdewin.</div>
<div>By Thomas Friedrichsmeier.</div>
<p style="color: grey;"><i>Updated March 5, 2016, 4:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
emerge
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For some reason, an emerge build will install Qt plugins not in just one, but in three separate directories (KDEROOT/plugins, KDEROOT/lib/plugins, KDEROOT/plugin). I have not investigated why this is the case, or how that could be changed. However, I assume that may not be trivial.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To make applications work in that setup, Qt needs to be informed of the plugin paths. Since qt.conf supports only a single path, that cannot be used, for this. Rather, emerge sets the QT_PLUGIN_PATH environment variable. While this works, it also makes it difficult to deploy any application. In fact, currently, a MinGW compiled, NSIS-packaged app will not run at all, because Qt can't find the windows platform plugin. (I do seem to remember, but have not tried, again, that an MSVC-compiled application was not affected by this, for some reason). Copying the platform-plugin to KDEROOT/bin would work around this, but Qt would still not find any other plugin, then.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Clearly, installers <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">could</em> be adjusted to set QT_PLUGIN_PATH on the target system. However, this could interfere badly with parallel installations of Qt/KF5, and it would prevent nice-to-have features such as being able to move an installed KF5 application to a different path (e.g. on a thumb drive), or in fact moving an entire emerge tree.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Long story short, the only way I can see to support all required plugin paths without the need for QT_PLUGIN_PATH, is to patch them into QCoreApplication, which is what this diff does. After a certain grace-period, it would also make sense to remove the corresponding init code from EmergeSetupHelper.py.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Built qtbase from scratch on MinGW.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Packaged RKWard and deployed it on a separate system, successfully.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Also deployed kate, and verified that it can find its plugins.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Renamed KDEROOT and started applications in it, successfully, too.</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note that I tested with qt 5.5, only. Importantly, I did not test with 5.6 (or 5.4), altough emerge will (try to?) apply the patch, there, too.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>portage/libs/qt5/qtbase/qtbase-pluginpaths.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/libs/qt5/qtbase/qtbase.py <span style="color: grey">(3331952)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127288/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>