<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127239/">https://git.reviewboard.kde.org/r/127239/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdewin.</div>
<div>By Thomas Friedrichsmeier.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
emerge
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">NSIS Packager has code to include the VC redistributable libs for MSVC 2015. This patch does two things:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">a) Try to support non-standard installation directories of MSVC. It does this by locating cl.exe, then using relative paths from that. Since somehow emerge is capable of finding my install of MSVC 2013 in a non-standard location, before it is in the path, I assume a more elegant way does exist. Unfortunately, I have not been able to find out how that is done. Arguably, though, the solution suggested, here, is still <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">more</em> elegant than using a hard-coded (default) installation path.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">b) Include the redistributable libs for older MSVC in the package, too. MSVC 2013 does not appear to ship vc_redist[arch].exe, so I'm doing that by copying the libs from VC's redist folder to the "bin" folder of the archive.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For the moment, the code will bail out with an error message for MinGW, as it there is little point in producing installers installing non-runnable applications. It should be rather straightforward to add a solution along the lines of b) for MinGW, too, however.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested with MSVC 2013 for RKWard. Installer is created successfully, and the installed application is runnable (while it was not, without the patch).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Not</em> tested with MSVC 2015.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>bin/Packager/NullsoftInstallerPackager.py <span style="color: grey">(7155f800b916714bcaf370f501b101650c1302bc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127239/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>