<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124881/">https://git.reviewboard.kde.org/r/124881/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 25th, 2015, 7:41 vorm. UTC, <b>Patrick Spendrin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hm, I'd prefer if we could fix the issue itself instead? Maybe we can also update gsl (if it hasn't happened yet).</p></pre>
</blockquote>
<p>On August 26th, 2015, 6:57 nachm. UTC, <b>Michael Abrahams</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">GSL 1.16 is still the most recent version, but I can update the tag to point to the most recent commit from the AMPL repo.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The error is this: </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Linking C executable bin\cdf_test.exe
gsl.lib(pow_int.c.obj) : error LNK2005: gsl_pow_3 already defined in gsl.lib(gamma_inc.c.obj)
bin\cdf_test.exe : fatal error LNK1169: one or more multiply defined symbols found
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would also prefer the underlying issue be fixed. I looked into it, but the solution was not obvious to me. Maybe it has something to do with C inlining rules?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The multiply defined function gsl_pow_3 is defined inline: https://github.com/ampl/gsl/blob/master/gsl_pow_int.h
The function is in fact used in this file, where the compiler complains, thus gsl_pow_int.h must have been included somewhere: https://github.com/ampl/gsl/blob/master/specfunc/gamma_inc.c</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">could you check if gsl gitHEAD doesn't work? because there has been exactly such a last commit (fixing msvc2015 inline)....
If yes, then lets simply update our fixed revision for the 1.16 target.</p></pre>
<br />
<p>- Patrick</p>
<br />
<p>On August 22nd, 2015, 3:43 nachm. UTC, Michael Abrahams wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdewin.</div>
<div>By Michael Abrahams.</div>
<p style="color: grey;"><i>Updated Aug. 22, 2015, 3:43 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
emerge
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Silences a linking error with multiply defined symbols in cdf/test.c in MSVC 2015</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>portage/win32libs/gsl/gsl-disable-testing-msvc.patch <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/win32libs/gsl/gsl.py <span style="color: grey">(8432312)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124881/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>