<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124760/">https://git.reviewboard.kde.org/r/124760/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 18th, 2015, 5:51 p.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We have a patch that fixes a crash in shared-mime-info:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">From <span style="color: #666666">83</span>e045ee8df2ab408af585712d11db960d4de502 Mon Sep <span style="color: #666666">17</span> <span style="color: #666666">00:00:00</span> <span style="color: #666666">2001</span>
From<span style="color: #666666">:</span> Gleb Popov <span style="color: #666666"><6</span>yearold<span style="border: 1px solid #FF0000">@</span>gmail.com<span style="color: #666666">></span>
<span style="color: #008000">Date</span><span style="color: #666666">:</span> Tue, <span style="color: #666666">18</span> Aug <span style="color: #666666">2015</span> <span style="color: #666666">19:36:44</span> <span style="color: #666666">+0300</span>
Subject<span style="color: #666666">:</span> <span style="color: #BC7A00">[</span>PATCH<span style="color: #BC7A00">]</span> Fix update<span style="color: #666666">-</span>mime<span style="color: #666666">-</span>info. VS was picking wrong <span style="color: #008000; font-weight: bold">function</span> types <span style="color: #008000; font-weight: bold">for</span>
opendir<span style="color: #666666">/</span>readdir because there was no prototypes <span style="color: #008000; font-weight: bold">for</span> them <span style="color: #008000; font-weight: bold">in</span> dirent.h, which
lead to crash. The second crash was due to writing <span style="color: #666666">8-</span><span style="color: #008000; font-weight: bold">byte</span> intptr_t value
returned by _findfirst() into a <span style="color: #666666">4-</span><span style="color: #008000; font-weight: bold">byte</span> <span style="color: #008000; font-weight: bold">long</span> variable. No idea how it was
working before.
<span style="color: #666666">---</span>
portage<span style="color: #666666">/</span>win32libs<span style="color: #666666">/</span>shared<span style="color: #666666">-</span>mime<span style="color: #666666">-</span>info<span style="color: #666666">/</span>dirent.c <span style="color: #666666">|</span> <span style="color: #666666">2</span> <span style="color: #666666">+-</span>
portage<span style="color: #666666">/</span>win32libs<span style="color: #666666">/</span>shared<span style="color: #666666">-</span>mime<span style="color: #666666">-</span>info<span style="color: #666666">/</span>dirent.h <span style="color: #666666">|</span> <span style="color: #666666">7</span> <span style="color: #666666">++++++-</span>
<span style="color: #666666">2</span> files changed, <span style="color: #666666">7</span> insertions(<span style="color: #666666">+</span>), <span style="color: #666666">2</span> deletions(<span style="color: #666666">-</span>)
diff <span style="color: #666666">--</span>git a<span style="color: #666666">/</span>portage<span style="color: #666666">/</span>win32libs<span style="color: #666666">/</span>shared<span style="color: #666666">-</span>mime<span style="color: #666666">-</span>info<span style="color: #666666">/</span>dirent.c b<span style="color: #666666">/</span>portage<span style="color: #666666">/</span>win32libs<span style="color: #666666">/</span>shared<span style="color: #666666">-</span>mime<span style="color: #666666">-</span>info<span style="color: #666666">/</span>dirent.c
index <span style="color: #666666">2</span>ca945a..c35ae29 <span style="color: #666666">100644</span>
<span style="color: #666666">---</span> a<span style="color: #666666">/</span>portage<span style="color: #666666">/</span>win32libs<span style="color: #666666">/</span>shared<span style="color: #666666">-</span>mime<span style="color: #666666">-</span>info<span style="color: #666666">/</span>dirent.c
<span style="color: #666666">+++</span> b<span style="color: #666666">/</span>portage<span style="color: #666666">/</span>win32libs<span style="color: #666666">/</span>shared<span style="color: #666666">-</span>mime<span style="color: #666666">-</span>info<span style="color: #666666">/</span>dirent.c
<span style="border: 1px solid #FF0000">@@</span> <span style="color: #666666">-83</span>,<span style="color: #666666">7</span> <span style="color: #666666">+83</span>,<span style="color: #666666">7</span> <span style="border: 1px solid #FF0000">@@</span> DIR <span style="color: #666666">*</span> opendir(<span style="color: #008000; font-weight: bold">const</span> <span style="color: #008000; font-weight: bold">char</span> <span style="color: #666666">*</span>dir)
{
DIR <span style="color: #666666">*</span>dp;
<span style="color: #008000; font-weight: bold">char</span> <span style="color: #666666">*</span>filespec;
<span style="color: #666666">-</span> <span style="color: #008000; font-weight: bold">long</span> handle;
<span style="color: #666666">+</span> intptr_t handle;
<span style="color: #008000; font-weight: bold">int</span> index;
filespec <span style="color: #666666">=</span> malloc(strlen(dir) <span style="color: #666666">+</span> <span style="color: #666666">2</span> <span style="color: #666666">+</span> <span style="color: #666666">1</span>);
diff <span style="color: #666666">--</span>git a<span style="color: #666666">/</span>portage<span style="color: #666666">/</span>win32libs<span style="color: #666666">/</span>shared<span style="color: #666666">-</span>mime<span style="color: #666666">-</span>info<span style="color: #666666">/</span>dirent.h b<span style="color: #666666">/</span>portage<span style="color: #666666">/</span>win32libs<span style="color: #666666">/</span>shared<span style="color: #666666">-</span>mime<span style="color: #666666">-</span>info<span style="color: #666666">/</span>dirent.h
index b98296a..bb4b837 <span style="color: #666666">100644</span>
<span style="color: #666666">---</span> a<span style="color: #666666">/</span>portage<span style="color: #666666">/</span>win32libs<span style="color: #666666">/</span>shared<span style="color: #666666">-</span>mime<span style="color: #666666">-</span>info<span style="color: #666666">/</span>dirent.h
<span style="color: #666666">+++</span> b<span style="color: #666666">/</span>portage<span style="color: #666666">/</span>win32libs<span style="color: #666666">/</span>shared<span style="color: #666666">-</span>mime<span style="color: #666666">-</span>info<span style="color: #666666">/</span>dirent.h
<span style="border: 1px solid #FF0000">@@</span> <span style="color: #666666">-73</span>,<span style="color: #666666">7</span> <span style="color: #666666">+73</span>,<span style="color: #666666">7</span> <span style="border: 1px solid #FF0000">@@</span> struct dirent {
<span style="color: #408080; font-style: italic">/* typedef DIR - not the same as Unix */</span>
typedef struct {
<span style="color: #666666">-</span> <span style="color: #008000; font-weight: bold">long</span> handle; <span style="color: #408080; font-style: italic">/* _findfirst/_findnext handle */</span>
<span style="color: #666666">+</span> intptr_t handle; <span style="color: #408080; font-style: italic">/* _findfirst/_findnext handle */</span>
<span style="color: #008000; font-weight: bold">short</span> offset; <span style="color: #408080; font-style: italic">/* offset into directory */</span>
<span style="color: #008000; font-weight: bold">short</span> finished; <span style="color: #408080; font-style: italic">/* 1 if there are not more files */</span>
struct _finddata_t fileinfo; <span style="color: #408080; font-style: italic">/* from _findfirst/_findnext */</span>
<span style="border: 1px solid #FF0000">@@</span> <span style="color: #666666">-81</span>,<span style="color: #666666">6</span> <span style="color: #666666">+81</span>,<span style="color: #666666">11</span> <span style="border: 1px solid #FF0000">@@</span> typedef struct {
struct dirent dent; <span style="color: #408080; font-style: italic">/* the dirent to return */</span>
} DIR;
<span style="color: #666666">+</span><span style="border: 1px solid #FF0000">#</span>ifndef __MINGW32__
<span style="color: #666666">+</span>DIR <span style="color: #666666">*</span> opendir(<span style="color: #008000; font-weight: bold">const</span> <span style="color: #008000; font-weight: bold">char</span> <span style="color: #666666">*</span>dir);
<span style="color: #666666">+</span>struct dirent <span style="color: #666666">*</span> readdir(DIR <span style="color: #666666">*</span>dp);
<span style="color: #666666">+</span><span style="border: 1px solid #FF0000">#</span>endif
<span style="color: #666666">+</span>
<span style="border: 1px solid #FF0000">#</span>ifdef __cplusplus
}
<span style="border: 1px solid #FF0000">#</span>endif
<span style="color: #666666">--</span>
<span style="color: #666666">1.8</span>.<span style="color: #666666">3</span>.msysgit.<span style="color: #666666">0</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Does that tackle the same issue? Do you know?</p></pre>
</blockquote>
<p>On August 18th, 2015, 6:07 p.m. UTC, <b>Michael Abrahams</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The intptr_t definition conflict seems familiar. I can try building again with that revision included, and perhaps the issue will be resolved. I will share compiler logs if it fails.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I built after reverting the change and everything seemed fine. This patch can be relinquished as a mystery lost to time.</p></pre>
<br />
<p>- Michael</p>
<br />
<p>On August 15th, 2015, 10:47 p.m. UTC, Michael Abrahams wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdewin.</div>
<div>By Michael Abrahams.</div>
<p style="color: grey;"><i>Updated Aug. 15, 2015, 10:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
emerge
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">These additions are part of my recent work building Krita on Windows with MSVC2013 and KDE Frameworks 5.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>portage/win32libs/shared-mime-info/unistd.c <span style="color: grey">(440b9e9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124760/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>