<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121078/">https://git.reviewboard.kde.org/r/121078/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks good to me, really useful and definitely a step forward towards a ported dolphin.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm saying shipit because I've ended having to do that in many projects already. Thanks!</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On November 8th, 2014, 10:25 p.m. UTC, Andrius da Costa Ribas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Base Apps, KDE Frameworks and kdewin.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Nov. 8, 2014, 10:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use CMake's generate_export_header whenever possible, and fix some inconsistent exports.
Also, use Q_DECL_EXPORT consistently across occurrences of kdemain for kdeinit apps (removing kdemacros.h where KDE_EXPORT was being in use).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/views/dolphinfileitemlistwidget.h <span style="color: grey">(5f7c181)</span></li>
<li>dolphin/src/views/dolphinitemlistview.h <span style="color: grey">(7fd72e5)</span></li>
<li>dolphin/src/views/versioncontrol/updateitemstatesthread.h <span style="color: grey">(9b744d5)</span></li>
<li>dolphin/src/views/versioncontrol/versioncontrolobserver.h <span style="color: grey">(034ef8b)</span></li>
<li>dolphin/src/views/viewmodecontroller.h <span style="color: grey">(9ea717a)</span></li>
<li>dolphin/src/views/viewproperties.h <span style="color: grey">(d3ea428)</span></li>
<li>keditbookmarks/kbookmarkmodel/CMakeLists.txt <span style="color: grey">(2f83af2)</span></li>
<li>keditbookmarks/kbookmarkmodel/kbookmarkmodel_export.h <span style="color: grey">(b759bf9)</span></li>
<li>keditbookmarks/main.cpp <span style="color: grey">(bc64193)</span></li>
<li>konqueror/client/kfmclient.cpp <span style="color: grey">(276452b)</span></li>
<li>konqueror/src/CMakeLists.txt <span style="color: grey">(6831c88)</span></li>
<li>konqueror/src/konq_statusbarmessagelabel.h <span style="color: grey">(a115d39)</span></li>
<li>konqueror/src/konqmain.cpp <span style="color: grey">(7a73231)</span></li>
<li>konqueror/src/konqprivate_export.h <span style="color: grey">(2dec78b)</span></li>
<li>dolphin/src/libdolphin_export.h <span style="color: grey">(ff0f125)</span></li>
<li>dolphin/src/main.cpp <span style="color: grey">(91d32a0)</span></li>
<li>dolphin/src/kitemviews/private/kitemlistviewlayouter.h <span style="color: grey">(0efcab1)</span></li>
<li>dolphin/src/CMakeLists.txt <span style="color: grey">(c074908)</span></li>
<li>dolphin/src/kitemviews/kfileitemlistview.h <span style="color: grey">(9f07c9d)</span></li>
<li>dolphin/src/kitemviews/kfileitemlistwidget.h <span style="color: grey">(b7061d3)</span></li>
<li>dolphin/src/kitemviews/kfileitemmodel.h <span style="color: grey">(535e0f3)</span></li>
<li>dolphin/src/kitemviews/kfileitemmodelrolesupdater.h <span style="color: grey">(e8b186a)</span></li>
<li>dolphin/src/kitemviews/kitemlistcontainer.h <span style="color: grey">(55a9a11)</span></li>
<li>dolphin/src/kitemviews/kitemlistcontroller.h <span style="color: grey">(99df531)</span></li>
<li>dolphin/src/kitemviews/kitemlistgroupheader.h <span style="color: grey">(66fe929)</span></li>
<li>dolphin/src/kitemviews/kitemlistheader.h <span style="color: grey">(fe2d0ac)</span></li>
<li>dolphin/src/kitemviews/kitemlistselectionmanager.h <span style="color: grey">(c4decd3)</span></li>
<li>dolphin/src/kitemviews/kitemliststyleoption.h <span style="color: grey">(782dd0e)</span></li>
<li>dolphin/src/kitemviews/kitemlistview.h <span style="color: grey">(cc0754f)</span></li>
<li>dolphin/src/kitemviews/kitemlistviewaccessible.h <span style="color: grey">(674f1d1)</span></li>
<li>dolphin/src/kitemviews/kitemlistwidget.h <span style="color: grey">(07fc789)</span></li>
<li>dolphin/src/kitemviews/kitemmodelbase.h <span style="color: grey">(283cfa5)</span></li>
<li>dolphin/src/kitemviews/kstandarditem.h <span style="color: grey">(59190bf)</span></li>
<li>dolphin/src/kitemviews/kstandarditemlistgroupheader.h <span style="color: grey">(871c93d)</span></li>
<li>dolphin/src/kitemviews/kstandarditemlistview.h <span style="color: grey">(eb07c7f)</span></li>
<li>dolphin/src/kitemviews/kstandarditemlistwidget.h <span style="color: grey">(7683f84)</span></li>
<li>dolphin/src/kitemviews/kstandarditemmodel.h <span style="color: grey">(9d1db1a)</span></li>
<li>dolphin/src/kitemviews/private/kbaloorolesprovider.h <span style="color: grey">(f1ad5c7)</span></li>
<li>dolphin/src/kitemviews/private/kfileitemmodeldirlister.h <span style="color: grey">(94a0e39)</span></li>
<li>dolphin/src/kitemviews/private/kfileitemmodelfilter.h <span style="color: grey">(e4fb0a2)</span></li>
<li>dolphin/src/kitemviews/private/kitemlistheaderwidget.h <span style="color: grey">(b99f45f)</span></li>
<li>dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h <span style="color: grey">(661178d)</span></li>
<li>dolphin/src/kitemviews/private/kitemlistrubberband.h <span style="color: grey">(aea58af)</span></li>
<li>dolphin/src/kitemviews/private/kitemlistselectiontoggle.h <span style="color: grey">(8a1a857)</span></li>
<li>dolphin/src/kitemviews/private/kitemlistsizehintresolver.h <span style="color: grey">(a0ad033)</span></li>
<li>dolphin/src/kitemviews/private/kitemlistsmoothscroller.h <span style="color: grey">(ea56822)</span></li>
<li>dolphin/src/kitemviews/private/kitemlistviewanimation.h <span style="color: grey">(e2e5338)</span></li>
<li>dolphin/src/kitemviews/private/kpixmapmodifier.h <span style="color: grey">(4f863c3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121078/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>