<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119313/">https://git.reviewboard.kde.org/r/119313/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdewin and Stephen Kelly.</div>
<div>By Andre Heinecke.</div>
<p style="color: grey;"><i>Updated Aug. 11, 2014, 9:17 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdepimlibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">GPGME does not build completly different libraries but rather 5<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
variants that only differ in the context but use the same sources<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
and export the same symbols otherwise.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
commit f8d8a1d64aab678b5fd380d5b9e85b6729d90cc0<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
introduced the usage of generate_export_header for all those<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
variants although it did not change the sources to actually<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
use those export headers / macros.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Previously all variants used gpgme++_export.h and defined<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
MAKE_GPGME___LIB to correctly select the export setting.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We now fall back on that behavior by defining gpgmepp_EXPORTS<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
when building the variants.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The dependency to GPGME_VANILLA_FOUND for all variants was<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
already there as the gpgme++_export.h header was installed<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
unconditionally.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiled gpgme++ from KDE 4.13 on Windows and built kdepim against it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>gpgme++/CMakeLists.txt <span style="color: grey">(7cc551e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119313/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>