<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118026/">https://git.reviewboard.kde.org/r/118026/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good, I don't remember what weird reason required us to use the current setup. If it becomes a problem, we have to modify it anyway.</pre>
<br />
<p>- Patrick Spendrin</p>
<br />
<p>On May 6th, 2014, 8:29 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and kdewin.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated May 6, 2014, 8:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kinit
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix KF5_ADD_KDEINIT_EXECUTABLE on Windows
No longer create an empty dummy library, instead create a static library
with all the sources and link the exectuable to that.
This fixes the build of Kate on Windows since some unit tests use
target_link_libraries(test kdeinit_kate) and since that library was empty
it would not contain the required symbols</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kate tests link now, didn't before</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9e34058ab612732adba50331db624d2c307da0dd)</span></li>
<li>KF5InitMacros.cmake <span style="color: grey">(1768bc96573ca0fabf6bf620e4ff0a3f5f3646a5)</span></li>
<li>kde5init_win32lib_dummy.cpp.in <span style="color: grey">(d727297578834ba2f2c3ee8f086c355244f116de)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118026/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>