<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116670/">https://git.reviewboard.kde.org/r/116670/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, kdewin, Alexander Richardson, and Harald Fernengel.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated March 12, 2014, 8:31 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The processing of documentation still using DocBookXML 4.2, which depends on kde4support, currently fails on our Jenkins instance where each module has a different installation prefix with an error like:
---------------------------
Generating kate.1
file:///usr/share/xml/docbook/schema/dtd/4.2/dbpoolx.mod:215: warning: failed
to load external entity "file:///srv/jenkins/install/linux/x86_64/g++/kf5-
qt5/frameworks/kde4support/inst/share/kdoctools5/customization/dtd/rdbpool.elements"
%rdbpool;
^
Entity: line 1:
%rdbpool;
^
---------------------------
and similar for the other element/entity files referred. This does not happen in the "normal" installation because in that case those files will be found in the same directory ($prefix/share/kdoctools5/customization/dtd) and the relative path will work.
The attached patch change the paths in the compatibiliy DTD to be absolute path instead.
I have to question about this solution (kdewin group): will it work on windows? I guess so, as the directory returned by KDOCTOOLS_CUSTOMIZATION_DIR is set by KF5DocToolsConfig.cmake using KDOCTOOLS_DATA_INSTALL_DIR which uses PACKAGE_PREFIX_DIR, but I'm not totally sure.
Similar question for MacOSX.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles, and a module whose documentation still uses the old DTD (oktate) compiles correctly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/customization/dtd/kdex.dtd.cmake <span style="color: grey">(1f75dd9)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(d436846)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116670/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>