<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115457/">https://git.reviewboard.kde.org/r/115457/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks sensible to me</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115457/diff/1/?file=241700#file241700line202" style="color: black; font-weight: bold; text-decoration: underline;">src/kjs/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">194</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_compile_definitions</span><span class="p">(</span><span class="s">KF5JS</span> <span class="s">PRIVATE</span> <span class="s">MAKE_KJS_LIB=1</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why is KJS using its own home-cooked export macros instead of the ECM ones? The API *does* use the ECM-generated export header.
Well, JavaScript interpreters are dark beasts I'm not sure I want to get into...</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115457/diff/1/?file=241700#file241700line217" style="color: black; font-weight: bold; text-decoration: underline;">src/kjs/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">215</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># 'kjs_bin' because cmake doesn't like having a lib and app with the same name</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">209</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># 'kjs_bin' because cmake doesn't like having a lib and app with the same name</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">216</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># This is a developer tool, not intended for normal user installs</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">210</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># This is a developer tool, not intended for normal user installs</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">217</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">add_executable</span><span class="p">(</span><span class="s">kjs_bin</span> <span class="o">${</span><span class="nv">kjs_SRCS</span><span class="o">}</span><span class="p">)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">211</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">add_executable</span><span class="p">(</span><span class="s">kjs_bin</span> <span class="o">${</span><span class="nv">kjs_SRCS</span><span class="o">}</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Huh. It occurs to me that this no longer applies now that the library is called kf5js... Not that this is relevant to your request.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115457/diff/1/?file=241703#file241703line122" style="color: black; font-weight: bold; text-decoration: underline;">src/wtf/MathExtras.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">inline double wtf_atan2(double x, double y)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">122</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#if COMPILER(MSVC)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">121</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#if COMPILER(MSVC)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Huh? So this is a nested #if COMPILER(MSVC)? I think the inner one should go...</pre>
</div>
<br />
<p>- Alex Merry</p>
<br />
<p>On February 4th, 2014, 12:10 a.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and kdewin.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2014, 12:10 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kjs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A few small commits, I only made one review request since it is only a small patch alltogether
Use the correct define _WIN32 instead of WIN32
This fixes the build with MSVC
-----------------------------
Fix MSVC linking of the test executables
-------------------------------
Fix includes on Windows
timeapi.h is needed for timeGetTime() and xmath.h no longer exists with
newer MSVC versions
------------------------------------------------------
Fix the PLATFORM(), COMPILER() etc. macros on MSVC
MSVC does not handle expanding defined() inside macros
-------------------------------------------------
Fix linkage on MSVC
We have to define MAKE_KJS_LIB to get dllimport/dllexport right
-------------------------------------------------------
Get rid of KDEWIN_INCLUDES and KDEWIN_LIBRARIES
These variables no longer exist
------------------------------------------------------------
Use ecm_mark_nongui_executable to fix linking on Windows</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(99b0c4edd1f641900527ea79b13dba230a1025e2)</span></li>
<li>src/kjs/function.h <span style="color: grey">(c09bd385ff2aa1dd48a80aa1032d26787514ce04)</span></li>
<li>src/kjs/object.h <span style="color: grey">(e2279cb026783dee1ffb2c737f6181de0f41464f)</span></li>
<li>src/wtf/MathExtras.h <span style="color: grey">(50fb006a259797b16bfce09b5e2d101cf127fb38)</span></li>
<li>src/wtf/Platform.h <span style="color: grey">(39e55dac1ba69feee47b8609cf05b91541f9740b)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(71664cc7dd4df31ed56243440666217e1177619c)</span></li>
<li>tests/testkjs.cpp <span style="color: grey">(a00ed144b54896842beb9a6519d107fdff102319)</span></li>
<li>src/kjs/CMakeLists.txt <span style="color: grey">(c1c8cef2bf1e44c8d762d6894310ce68ca05b2d7)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(1268b8a6555fd36cd73f97beb6989b21056160f0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115457/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>