<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107235/">http://git.reviewboard.kde.org/r/107235/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 0ec4eef6f5e12aed402087646c426863fbe9f1e6 by Martin Klapetek to branch KDE/4.10.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 10th, 2012, 12:32 p.m., Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDEPIM, KDEPIM-Libraries and kdewin.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2012, 12:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks to bug 308763 we noticed couple issues, here's what this fixes:
* Adds assignment operator
* Moves the private class to separate file
* Gets rid of PostReply class and replace it with SocialFeedItem itself (they are practically the same)
* Fix typo/bad-copy-paste-job in _export.h file
This should hopefully fix the windows build as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with facebook resource, all compiles and works.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=308763">308763</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>akonadi/socialutils/libakonadisocialutils_export.h <span style="color: grey">(106fbdc)</span></li>
<li>akonadi/socialutils/serializer/akonadi_serializer_socialfeeditem.cpp <span style="color: grey">(a153d92)</span></li>
<li>akonadi/socialutils/socialfeeditem.h <span style="color: grey">(2cbabe9)</span></li>
<li>akonadi/socialutils/socialfeeditem.cpp <span style="color: grey">(6d6572b)</span></li>
<li>akonadi/socialutils/socialfeeditem_p.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107235/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>