<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106534/">http://git.reviewboard.kde.org/r/106534/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 58f8943a1967bddc3c6efeb730d623653c142f0f by Aleix Pol to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 22nd, 2012, 8:29 p.m., Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdewin, Patrick Spendrin and Patrick von Reth.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 22, 2012, 8:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi, since I wanted to see what is possible and what not with the kdewin installer I decided to take a look into the code and compile it and all.
Here I'm sending the changes I had to make so that it worked properly.
I understand you might want some of the changes and some not, but I think there are some good changes like proper casing in includes or fixing the non-static compilation that can be useful.
Feel free to reject it anyway :P.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled it on Archlinux, made it run for a bit xD.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>3rdparty/CMakeLists.txt <span style="color: grey">(65cf501)</span></li>
<li>CMakeLists.txt <span style="color: grey">(f62fea8)</span></li>
<li>shared/CMakeLists.txt <span style="color: grey">(3257b62)</span></li>
<li>shared/externalinstallercontrol.cpp <span style="color: grey">(018ff96)</span></li>
<li>shared/installercallconfig.cpp <span style="color: grey">(b290298)</span></li>
<li>shared/installerengine.cpp <span style="color: grey">(181a504)</span></li>
<li>shared/settings.cpp <span style="color: grey">(419349c)</span></li>
<li>single-package-installer/CMakeLists.txt <span style="color: grey">(0b0de3d)</span></li>
<li>single-package-installer/installerdialog.h <span style="color: grey">(1619025)</span></li>
<li>single-package-installer/installerenginesinglepackage.cpp <span style="color: grey">(fc43a26)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106534/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>