<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106534/">http://git.reviewboard.kde.org/r/106534/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 22nd, 2012, 10:56 p.m., <b>Patrick Spendrin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106534/diff/1/?file=86816#file86816line68" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> set (STATIC_BUILD 1)</pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">68</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> set (STATIC_BUILD 1)</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, this looks suspicious that you don't have QT_CONFIG shared; no idea how portable our tests are at that point though. (maybe make a comment here if you can find out why it is like that.)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">CONFIG += def_files_disabled exceptions no_mocdepend release stl qt_no_framework
That's my QT_CONFIG value...</pre>
<br />
<p>- Aleix</p>
<br />
<p>On September 22nd, 2012, 8:29 p.m., Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdewin, Patrick Spendrin and Patrick von Reth.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 22, 2012, 8:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi, since I wanted to see what is possible and what not with the kdewin installer I decided to take a look into the code and compile it and all.
Here I'm sending the changes I had to make so that it worked properly.
I understand you might want some of the changes and some not, but I think there are some good changes like proper casing in includes or fixing the non-static compilation that can be useful.
Feel free to reject it anyway :P.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled it on Archlinux, made it run for a bit xD.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>3rdparty/CMakeLists.txt <span style="color: grey">(65cf501)</span></li>
<li>CMakeLists.txt <span style="color: grey">(f62fea8)</span></li>
<li>shared/CMakeLists.txt <span style="color: grey">(3257b62)</span></li>
<li>shared/externalinstallercontrol.cpp <span style="color: grey">(018ff96)</span></li>
<li>shared/installercallconfig.cpp <span style="color: grey">(b290298)</span></li>
<li>shared/installerengine.cpp <span style="color: grey">(181a504)</span></li>
<li>shared/settings.cpp <span style="color: grey">(419349c)</span></li>
<li>single-package-installer/CMakeLists.txt <span style="color: grey">(0b0de3d)</span></li>
<li>single-package-installer/installerdialog.h <span style="color: grey">(1619025)</span></li>
<li>single-package-installer/installerenginesinglepackage.cpp <span style="color: grey">(fc43a26)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106534/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>