<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106423/">http://git.reviewboard.kde.org/r/106423/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 11th, 2012, 6:55 a.m., <b>Wolfgang Rohdewald</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106423/diff/1/?file=84964#file84964line10" style="color: black; font-weight: bold; text-decoration: underline;">portage/kde/kdegames/kajongg/kajongg-20120911.py</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def setDependencies( self ):</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">10</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="bp">self</span><span class="o">.</span><span class="n">dependencies</span><span class="p">[</span><span class="s">'kde/libkdegame'</span><span class="p">]</span> <span class="o">=</span> <span class="s">'default'</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kajongg will not run on windows unless you get PyKDE4 running first. And it has very different dependencies, libkdegames not being one of them.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Interesting why I left the "libkdegame" in.
1) Should usually be "libkdegames" like all the other files of this change.
2) I have even checked the https://projects.kde.org/projects/kde/kdegames/kajongg/repository/revisions/master/entry/CMakeLists.txt file, and I intended to refactor the dependency.
3) There is pykde in testing, but I do not know if that is functioning. If someone cannot tell off-hand, then I will see when testing these packages.
4) KDE Windows switched to python 3 iirc, and it might be that pykde still requires an older version. I am unsure about that as well.
5) There is also the problem, I raised on kde-games-devel, about the KPatience - kpat inconsistency which hopefully needs to be fixed. I went for the current "kde:kpat" way, but I would personally appreciate "kde:kpatience" (i.e. not to retain the svn folder name unless this is needed for any backward compatibility).</pre>
<br />
<p>- Laszlo</p>
<br />
<p>On September 11th, 2012, 6:47 a.m., Laszlo Papp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdewin and Patrick Spendrin.</div>
<div>By Laszlo Papp.</div>
<p style="color: grey;"><i>Updated Sept. 11, 2012, 6:47 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is just for checking the direction I have picked up. The patch mimics the kdeedu infrastructure in emerge/portage.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yet to be tested on Windows.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>portage/kde/kdegames/bomber/bomber-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/bovo/bovo-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/granatier/granatier-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kajongg/kajongg-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kapman/kapman-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/katomic/katomic-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kblackbox/kblackbox-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kblocks/kblocks-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kbounce/kbounce-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kbreakout/kbreakout-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kdegames-20080202.py <span style="color: grey">(9075ffb)</span></li>
<li>portage/kde/kdegames/kdegames-package.xml <span style="color: grey">(19c06f8)</span></li>
<li>portage/kde/kdegames/kdiamond/kdiamond-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kfourinline/kfourinline-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kgoldrunner/kgoldrunner-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kigo/kigo-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/killbots/killbots-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kiriki/kiriki-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kjumpingcube/kjumpingcube-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/klickety/klickety-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/klines/klines-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kmahjongg/kmahjongg-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kmines/kmines-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/knavalbattle/knavalbattle-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/knetwalk/knetwalk-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kolf/kolf-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kollision/kollision-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/konquest/konquest-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kpatience/kpatience-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kreversi/kreversi-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kshisen/kshisen-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/ksirk/ksirk-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/ksnakeduel/ksnakeduel-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kspaceduel/kspaceduel-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/ksquares/ksquares-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/ksudoku/ksudoku-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/ktuberling/ktuberling-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/kubrick/kubrick-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/libkdegames/libkdegames-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/libmahjongg/libmahjongg-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/lskat/lskat-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/palapeli/palapeli-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>portage/kde/kdegames/picmi/picmi-20120911.py <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106423/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>