<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6656/">http://svn.reviewboard.kde.org/r/6656/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-windows.</div>
<div>By Michael Drüing.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a patch for emerge to add a CMake recipe for libsdl-1.2
However, since this is my first CMake recipe, and indeed my first python code (except for a "hello world" some years ago ;-), I'd like some advice on a few points:
- in which directory (portage group) does it belong? I added it to "win32libs-sources" but maybe "testing" or "libs" would be a better place?
- the CMake file obviously only works on windows with the DirectX SDK installed, as it is currently hardcoded to use this specific configuration (I tried to stay as close to the original configure.in as possible). Do I need to make DirectX, OpenGL, etc. optional?
- Also, I don't know if it works on x64 or on mingw, as I am not set up to test these. If something needs changing for these build environments, please tell me</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested it on MSVC2008 and MSVC2010 and it works fine. I also included one test program from the libsdl distribution to see if opengl acceleration works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/home/kde/trunk/kdesupport/emerge/portage/win32libs-sources/libsdl-src/libsdl-src-1.2.14.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/home/kde/trunk/kdesupport/emerge/portage/win32libs-sources/libsdl-src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6656/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>