<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6501/">http://svn.reviewboard.kde.org/r/6501/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-windows.</div>
<div>By Wolfgang Rohdewald.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes several problems:
- sometimes emerge checks for True, sometimes for 1, sometimes for both
- emerge sometimes interprets every value as True, even False - like
EMERGE_NO_PASSIVE_FTP or EMERGE_ENABLE_IMPLICID_BUILDTIME_DEPENDENCIES.
emerge only checks if those variables are set, ignoring their value.
- EmergeBase.py interprets EMERGE_NOFAST the wrong way round.
This patch makes EmergeBase behave like base.py
- remove dead code in emerge.py
envAsBool accepts 'True' (ignoring case) and '1' for True, everything else is False.
The default for a non-existing environment variable can be passed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/kdesupport/emerge/bin/EmergeBase.py <span style="color: grey">(1221105)</span></li>
<li>/trunk/kdesupport/emerge/bin/InstallDB.py <span style="color: grey">(1221105)</span></li>
<li>/trunk/kdesupport/emerge/bin/Package/PackageBase.py <span style="color: grey">(1221105)</span></li>
<li>/trunk/kdesupport/emerge/bin/Packager/NullsoftInstallerPackager.py <span style="color: grey">(1221105)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/ArchiveSource.py <span style="color: grey">(1221105)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/GitSource.py <span style="color: grey">(1221105)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/SvnSource.py <span style="color: grey">(1221105)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/VersionSystemSourceBase.py <span style="color: grey">(1221105)</span></li>
<li>/trunk/kdesupport/emerge/bin/base.py <span style="color: grey">(1221107)</span></li>
<li>/trunk/kdesupport/emerge/bin/emerge.py <span style="color: grey">(1221119)</span></li>
<li>/trunk/kdesupport/emerge/bin/kde_build.py <span style="color: grey">(1221105)</span></li>
<li>/trunk/kdesupport/emerge/bin/options.py <span style="color: grey">(1221105)</span></li>
<li>/trunk/kdesupport/emerge/bin/portage.py <span style="color: grey">(1221105)</span></li>
<li>/trunk/kdesupport/emerge/bin/tools.py <span style="color: grey">(1221105)</span></li>
<li>/trunk/kdesupport/emerge/bin/utils.py <span style="color: grey">(1221105)</span></li>
<li>/trunk/kdesupport/emerge/bin/win32libsupdater.py <span style="color: grey">(1221105)</span></li>
<li>/trunk/kdesupport/emerge/portage/virtual/base/base-0.2.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/virtual/bin-base/bin-base-0.2.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/assuan2/assuan2-400.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/boost/boost-1.44.0-1.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/chm/chm-0.40.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/clucene-core/clucene-core-0.9.21b.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/cyrus-sasl/cyrus-sasl-2.1.22.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/djvu/djvu-3.5.23.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/ebook-tools/ebook-tools-0.2.1.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/exiv2/exiv2-0.21-2.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/expat/expat-2.0.1.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/freetype/freetype-2.3.12-2.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/gettext/gettext-0.18.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/giflib/giflib-4.1.6.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/gpg-error/gpg-error-267.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/gpgme/gpgme-1510.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/jasper/jasper-1.900.1-2.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/jpeg/jpeg-8.0.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/lcms/lcms-1.19-2.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libarchive/libarchive-2.8.4.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libbfd/libbfd-2.20.1.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libbzip2/libbzip2-1.0.6-1.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libcurl/libcurl-7.20.0.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libfftw/libfftw-3.2.2.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libical/libical-0.44.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libidn/libidn-1.19-5.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/liblzma/liblzma-5.0.0.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libmsn/libmsn-4.1-2.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libnova/libnova-0.13.0+svn270.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libogg/libogg-1.2.0.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libpng/libpng-1.4.4.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libsamplerate/libsamplerate-0.1.7.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libsndfile/libsndfile-1.0.21.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libspectre/libspectre-0.2.6.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libvorbis/libvorbis-1.3.1.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libxml2/libxml2-2.7.7.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libxslt/libxslt-1.1.26.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/libzip/libzip-0.9.3.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/openbabel/openbabel-2.2.3.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/openjpeg/openjpeg-1.3-2.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/openslp/openslp-1.2.1.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/openssl/openssl-1.0.0b.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/pcre/pcre-8.10.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/redland/redland-1.0.8.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/shared-mime-info/shared-mime-info-0.71-1.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/sqlite/sqlite-3.7.2.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/taglib-extras/taglib-extras-1.0.1.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/taglib/taglib-1.6.3.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/tiff/tiff-3.9.2.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/win_iconv/win_iconv-0.0.2.py <span style="color: grey">(1221099)</span></li>
<li>/trunk/kdesupport/emerge/portage/win32libs-bin/zlib/zlib-1.2.5.py <span style="color: grey">(1221099)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6501/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>