<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6484/">http://svn.reviewboard.kde.org/r/6484/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">good catch, this is very useful :-)
</pre>
<br />
<p>- Ralf</p>
<br />
<p>On February 15th, 2011, 8:12 a.m., Wolfgang Rohdewald wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-windows.</div>
<div>By Wolfgang Rohdewald.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2011, 8:12 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Python 2.7 allows to use open() as a context manager. This makes code simpler and ensures that files are always closed.
In some places emerge actually did not close files, even after writing to them. It is then depending on the python implementation if and when they are automatically written and closed - there is no guarantee they ever will.
I did not (yet) change emerge/portage, only emerge/bin</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/kdesupport/emerge/bin/BuildSystem/BuildSystemBase.py <span style="color: grey">(1220833)</span></li>
<li>/trunk/kdesupport/emerge/bin/BuildSystem/CMakeBuildSystem.py <span style="color: grey">(1220833)</span></li>
<li>/trunk/kdesupport/emerge/bin/BuildSystem/CMakeDependencies.py <span style="color: grey">(1220833)</span></li>
<li>/trunk/kdesupport/emerge/bin/InstallDB.py <span style="color: grey">(1220833)</span></li>
<li>/trunk/kdesupport/emerge/bin/Packager/InnoSetupPackager.py <span style="color: grey">(1220833)</span></li>
<li>/trunk/kdesupport/emerge/bin/Packager/PackagerBase.py <span style="color: grey">(1220833)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/HgSource.py <span style="color: grey">(1220833)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/SvnSource.py <span style="color: grey">(1220833)</span></li>
<li>/trunk/kdesupport/emerge/bin/options.py <span style="color: grey">(1220833)</span></li>
<li>/trunk/kdesupport/emerge/bin/package_definition_viewer.py <span style="color: grey">(1220833)</span></li>
<li>/trunk/kdesupport/emerge/bin/portage.py <span style="color: grey">(1220833)</span></li>
<li>/trunk/kdesupport/emerge/bin/tools.py <span style="color: grey">(1220833)</span></li>
<li>/trunk/kdesupport/emerge/bin/update.py <span style="color: grey">(1220833)</span></li>
<li>/trunk/kdesupport/emerge/bin/utils.py <span style="color: grey">(1220833)</span></li>
<li>/trunk/kdesupport/emerge/bin/xml2conf.py <span style="color: grey">(1220833)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6484/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>