<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6345/">http://svn.reviewboard.kde.org/r/6345/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good</pre>
<br />
<p>- Ralf</p>
<br />
<p>On January 16th, 2011, 11:28 p.m., Wolfgang Rohdewald wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-windows.</div>
<div>By Wolfgang Rohdewald.</div>
<p style="color: grey;"><i>Updated Jan. 16, 2011, 11:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> EmergeBase.__init__: if the object does not yet have attribute
buildSystemType, set it to None. This makes referencing this
attribute easier because "if hasattr()" is no longer needed. And
it makes pylint happy.
The same thing has already been done with subinfo, r1214441, which
resulted in no complaints or problems
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/kdesupport/emerge/bin/EmergeBase.py <span style="color: grey">(1214807)</span></li>
<li>/trunk/kdesupport/emerge/bin/Package/PackageBase.py <span style="color: grey">(1214807)</span></li>
<li>/trunk/kdesupport/emerge/bin/Packager/NullsoftInstallerPackager.py <span style="color: grey">(1214807)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/ArchiveSource.py <span style="color: grey">(1214807)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/FileSource.py <span style="color: grey">(1214807)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/SourceBase.py <span style="color: grey">(1214807)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6345/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>