<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6207/">http://svn.reviewboard.kde.org/r/6207/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for kde-windows, kdelibs, Peter Penz, Pino Toscano, Fredrik Höglund, David Faure, and Patrick Spendrin.</div>
<div>By Andrius Ribas.</div>


<p style="color: grey;"><i>Updated 2011-01-01 14:04:10.460100</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A simple &quot;computer&quot; kioslave, showing the drive letters on &quot;/&quot;, and redirecting to &quot;file&quot; otherwise.
Additionaly this patch substitutes &quot;root&quot; on Konqueror sidebar, by &quot;computer&quot;, also this changes the &quot;places&quot; panel (see below).


(as reviewboard only supports single patches) additional patch for the &quot;places&quot; panel on trunk/KDE/kdelibs:

Index: kfile/kfileplacesmodel.cpp
===================================================================
--- kfile/kfileplacesmodel.cpp        (revision 1209174)
+++ kfile/kfileplacesmodel.cpp        (working copy)
@@ -120,40 +120,9 @@
                                               &quot;Network&quot;, I18N_NOOP2(&quot;KFile System Bookmarks&quot;, &quot;Network&quot;),
                                               KUrl(&quot;remote:/&quot;), &quot;network-workgroup&quot;);
 #ifdef Q_OS_WIN
-        // adding drives
-        foreach ( const QFileInfo&amp; info, QDir::drives() ) {
-#ifndef _WIN32_WCE
-            uint type = DRIVE_UNKNOWN;
-#endif
-            QString driveIcon = &quot;drive-harddisk&quot;;
-#ifndef _WIN32_WCE
-            QT_WA({ type = GetDriveTypeW((wchar_t *)info.absoluteFilePath().utf16()); },
-                  { type = GetDriveTypeA(info.absoluteFilePath().toLocal8Bit()); });
-            // qDebug() &lt;&lt; &quot;drive &quot; &lt;&lt; info.absoluteFilePath() &lt;&lt; &quot; type: &quot; &lt;&lt; type;
-            switch (type) {
-                case DRIVE_REMOVABLE:
-                    driveIcon = &quot;drive-removable-media&quot;;
-                    break;
-                case DRIVE_FIXED:
-                    driveIcon = &quot;drive-harddisk&quot;;
-                    break;
-                case DRIVE_REMOTE:
-                    driveIcon = &quot;network-server&quot;;
-                    break;
-                case DRIVE_CDROM:
-                    driveIcon = &quot;drive-optical&quot;;
-                    break;
-                case DRIVE_RAMDISK:
-                case DRIVE_UNKNOWN:
-                case DRIVE_NO_ROOT_DIR:
-                default:
-                    driveIcon = &quot;drive-harddisk&quot;;
-            }
-#endif
-            KFilePlacesItem::createSystemBookmark(d-&gt;bookmarkManager,
-                                                  info.absoluteFilePath(), info.absoluteFilePath(),
-                                                  KUrl(info.absoluteFilePath()), driveIcon);
-        }
+        KFilePlacesItem::createSystemBookmark(d-&gt;bookmarkManager,
+                                              &quot;Computer&quot;, I18N_NOOP2(&quot;KFile System Bookmarks&quot;, &quot;Computer&quot;),
+                                              KUrl(&quot;computer:&quot;), &quot;Computer&quot;);
 #else
         KFilePlacesItem::createSystemBookmark(d-&gt;bookmarkManager,
                                               &quot;Root&quot;, I18N_NOOP2(&quot;KFile System Bookmarks&quot;, &quot;Root&quot;),
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested using MSVC 2008 on a windows 7 machine</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=163448">163448</a>, 

 <a href="https://bugs.kde.org/show_bug.cgi?id=169628">169628</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdebase/apps/konqueror/sidebar/default_entries/CMakeLists.txt <span style="color: grey">(1209179)</span></li>

 <li>trunk/KDE/kdebase/apps/konqueror/sidebar/default_entries/computer.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdebase/runtime/kioslave/CMakeLists.txt <span style="color: grey">(1209179)</span></li>

 <li>trunk/KDE/kdebase/runtime/kioslave/computer/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdebase/runtime/kioslave/computer/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdebase/runtime/kioslave/computer/computer.protocol <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdebase/runtime/kioslave/computer/kio_computer.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdebase/runtime/kioslave/computer/kio_computer.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6207/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://svn.reviewboard.kde.org/r/6207/s/589/"><img src="http://svn.reviewboard.kde.org" style="border: 1px black solid;" alt="Konqueror with sidebar" /></a>

 <a href="http://svn.reviewboard.kde.org/r/6207/s/590/"><img src="http://svn.reviewboard.kde.org" style="border: 1px black solid;" alt="Dolphin" /></a>

</div>


  </td>
 </tr>
</table>




  </div>
 </body>
</html>