<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5527/">http://svn.reviewboard.kde.org/r/5527/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From KDE on Windows point of view this seems to be ok, although we might have to think about whether to extend this to other modules/generalize this.</pre>
<br />
<p>- Patrick</p>
<br />
<p>On October 5th, 2010, 5:08 a.m., Gregory Schlomoff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-windows, kdelibs and KDE PIM.</div>
<div>By Gregory Schlomoff.</div>
<p style="color: grey;"><i>Updated 2010-10-05 05:08:55</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a new CMake build option, STATIC_LIBRARY (defaults to FALSE), that enables static linking of the library. It applies to kdewin, akonadi, kdelibs, and kdepimlibs.
The ability to build those libraries statically already exists, however, it is tied to WinCE. With this patch, it becomes a build option, and building on WinCE automatically sets this option.
=== Notes ===
1. Naming
kdepim already has a similar option, and it's called KDEPIM_BUILD_STATIC. However, looking at a few other packages required to build KDE (namely, cyrus-sasl and sqlite), this option is called STATIC_LIBRARY in those places, so I'm assuming this is more standard. If you guys agree on this name, we could change KDEPIM_BUILD_STATIC to adopt the same convention. If you think however that this option should be named following the same pattern as kdepim, I'll update the patch accordingly.
2. C++ preprocessor definitions
Setting the STATIC_LIBRARY option to TRUE automatically adds the C++ preprocessor flag LIBRARYNAME_STATIC_LIBS, which is needed by the libraryname_export.h file to correctly import/export the symbols for static linking. However, it does not automatically assumes that dependencies of this library are also built statically, so one must manually sets the corresponding preprocessor flags for the dependencies of this library that have been built statically.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All testing done on Windows with MSVC. Works well here.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/CMakeLists.txt <span style="color: grey">(1182389)</span></li>
<li>/trunk/KDE/kdepimlibs/CMakeLists.txt <span style="color: grey">(1180605)</span></li>
<li>/trunk/kdesupport/akonadi/CMakeLists.txt <span style="color: grey">(1180610)</span></li>
<li>/trunk/kdesupport/kdewin/CMakeLists.txt <span style="color: grey">(1180610)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5527/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>