Review Request 117845: rename test as another exists with the same name

Vishesh Handa me at vhanda.in
Mon Apr 28 15:51:59 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/#review56771
-----------------------------------------------------------

Ship it!


Feel free to commit it after that.


src/file/tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117845/#comment39624>

    I would prefer if you kept the same test name and used set_target_properties
    
    Eg - set_target_properties(baloo_file_extractor_dummy
        PROPERTIES OUTPUT_NAME baloo_file_extractor
    )
    
    


- Vishesh Handa


On April 28, 2014, 3:33 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117845/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 3:33 p.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> rename test as another exists with the same name
> 
> 
> Diffs
> -----
> 
>   src/file/search/autotest/CMakeLists.txt 836ef2bfb29562aa36d8ebca8678932e5f01e0f3 
>   src/file/tests/CMakeLists.txt 7b914b2f6a9b37f5ed2397ef3cc9c38ec29aba0a 
> 
> Diff: https://git.reviewboard.kde.org/r/117845/diff/
> 
> 
> Testing
> -------
> 
> msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140428/2817cd93/attachment.html>


More information about the Kde-windows mailing list