Review Request 117131: Implement KUser::faceIconPath on Windows.

Commit Hook null at kde.org
Sat Apr 5 01:32:20 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117131/#review55008
-----------------------------------------------------------


This review has been submitted with commit c35ece00babf9a2ee0fd88a482e09ffa5cee9257 by Nicolás Alvarez to branch master.

- Commit Hook


On March 30, 2014, 3:35 p.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117131/
> -----------------------------------------------------------
> 
> (Updated March 30, 2014, 3:35 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Implement KUser::faceIconPath on Windows.
> 
> I use an undocumented Windows API (http://undoc.airesoft.co.uk/shell32.dll/SHGetUserPicturePath.php) that stores the profile image in a temporary file and returns the path to it. The previous code was just trying to load that temporary file, and would only work if another app had created the file recently (such as the control panel section where the image is changed).
> 
> This only works on Windows Vista and later; on Windows XP the undocumented API is different, and faceIconPath will just return an empty string.
> 
> 
> Diffs
> -----
> 
>   src/lib/util/kuser_win.cpp 96cf2f0 
> 
> Diff: https://git.reviewboard.kde.org/r/117131/diff/
> 
> 
> Testing
> -------
> 
> Compiled with MSVC2010, tested via the new faceicontest on Windows 7.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140405/e97656db/attachment.html>


More information about the Kde-windows mailing list