<table><tr><td style="">aacid added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23775">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23775#inline-134659">View Inline</a><span style="color: #4b4d51; font-weight: bold;">progressBox.cpp:92</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">m_text</span> <span style="color: #aa2211">=</span> <span class="n">i18np</span><span class="p">(</span><span style="color: #766510">"%1 File"</span><span class="p">,</span> <span style="color: #766510">"%1 Files"</span><span class="p">,</span> <span class="n">files</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_textWidth</span> <span style="color: #aa2211">=</span> <span class="n">fontMetrics</span><span class="p">().<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">width</span></span><span class="p">(</span><span class="n">m_text</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_textWidth</span> <span style="color: #aa2211">=</span> <span class="n">fontMetrics</span><span class="p">().<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">horizontalAdvance</span></span><span class="p">(</span><span class="n">m_text</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">m_textHeight</span> <span style="color: #aa2211">=</span> <span class="n">fontMetrics</span><span class="p">().</span><span class="n">height</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This increases the Qt dependency to 5.11, please change the CMakeLists.txt accordingly (or maybe try to use bondingRect and see if that works since that doesn't need a newer Qt than we need at tis point)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R352 Filelight</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23775">https://phabricator.kde.org/D23775</a></div></div><br /><div><strong>To: </strong>guoyunhe, KDE Applications<br /><strong>Cc: </strong>aacid, ngraham, KDE Applications, cfeck, kde-utils-devel<br /></div>