<table><tr><td style="">elvisangelaccio added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19766">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19766#inline-110852">View Inline</a><span style="color: #4b4d51; font-weight: bold;">rthomsen</span> wrote in <span style="color: #4b4d51; font-weight: bold;">cliinterface.cpp:928-931</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I removed this, since we shouldnt check for "file exists" messages when listing, right?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Probably yes, but please do mention this change in the commit message.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19766#inline-111288">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cliinterface.cpp:964</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">foreach</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">QString</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"></span><span class="n"><span class="bright">pattern</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">m_cliProps</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">property</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"f</span>ileExistsFileName<span class="bright">"</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">toStringList</span></span><span class="bright"></span><span class="p"><span class="bright">())</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">isF</span>ileExistsFileName<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">line</span></span><span class="bright"></span><span class="p"><span class="bright">))</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">pattern</span><span class="p">,</span> <span class="n">m_cliProps</span><span style="color: #aa2211">-></span><span class="n">property</span><span class="p">(</span><span style="color: #766510">"fileExistsFileNameRegExp"</span><span class="p">).</span><span class="n">toStringList</span><span class="p">())</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Coding style: brace should open at the end of previous line</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19766#inline-111289">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cliplugin.cpp:118</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"N"</span><span class="p">)});</span> <span style="color: #74777d">//Autoskip</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_cliProps</span><span style="color: #aa2211">-></span><span class="n">setProperty</span><span class="p">(</span><span style="color: #766510">"extractionFailedPatterns"</span><span class="p">,</span> <span class="n">QStringList</span><span class="p">{</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"unsupported compression method"</span><span class="p">)});</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_cliProps</span><span style="color: #aa2211">-></span><span class="n">setProperty</span><span class="p">(</span><span style="color: #766510">"corruptArchivePatterns"</span><span class="p">,</span> <span class="n">QStringList</span><span class="p">{</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"End-of-central-directory signature not found"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"didn't find end-of-central-dir signature at end of central dir"</span><span class="p">)});</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_cliProps</span><span style="color: #aa2211">-></span><span class="n">setProperty</span><span class="p">(</span><span style="color: #766510">"diskFullPatterns"</span><span class="p">,</span> <span class="n">QStringList</span><span class="p">{</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"write error </span><span style="color: #bb6622">\\</span><span style="color: #766510">(disk full</span><span style="color: #bb6622">\\</span><span style="color: #766510">?</span><span style="color: #bb6622">\\</span><span style="color: #766510">)"</span><span class="p">),</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unrelated, but I just noticed that we never define this property, am I wrong?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19766#inline-111290">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cliplugin.cpp:119-120</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_cliProps</span><span style="color: #aa2211">-></span><span class="n">setProperty</span><span class="p">(</span><span style="color: #766510">"extractionFailedPatterns"</span><span class="p">,</span> <span class="n">QStringList</span><span class="p">{</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"unsupported compression method"</span><span class="p">)});</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_cliProps</span><span style="color: #aa2211">-></span><span class="n">setProperty</span><span class="p">(</span><span style="color: #766510">"corruptArchivePatterns"</span><span class="p">,</span> <span class="n">QStringList</span><span class="p">{</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"End-of-central-directory signature not found"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"didn't find end-of-central-dir signature at end of central dir"</span><span class="p">)});</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_cliProps</span><span style="color: #aa2211">-></span><span class="n">setProperty</span><span class="p">(</span><span style="color: #766510">"diskFullPatterns"</span><span class="p">,</span> <span class="n">QStringList</span><span class="p">{</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"write error </span><span style="color: #bb6622">\\</span><span style="color: #766510">(disk full</span><span style="color: #bb6622">\\</span><span style="color: #766510">?</span><span style="color: #bb6622">\\</span><span style="color: #766510">)"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"No space left on device"</span><span class="p">)});</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What about this one? We are dropping the <tt style="background: #ebebeb; font-size: 13px;">diskFullPatterns</tt> property, aren't we?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R36 Ark</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19766">https://phabricator.kde.org/D19766</a></div></div><br /><div><strong>To: </strong>rthomsen, elvisangelaccio<br /><strong>Cc: </strong>kde-utils-devel, Ark, tctara<br /></div>