<table><tr><td style="">cfeck accepted this revision.<br />cfeck added a reviewer: teran.<br />cfeck added inline comments.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17901">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17901#inline-98498">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcalc.cpp:682</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">  <span style="color: #aa4000">int</span> <span class="n">margin</span> <span style="color: #aa2211">=</span> <span class="n">QApplication</span><span style="color: #aa2211">::</span><span class="n">style</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">pixelMetric</span><span class="p">(</span><span class="n">QStyle</span><span style="color: #aa2211">::</span><span class="n">PM_ButtonMargin</span><span class="p">,</span> <span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">int</span> <span class="n">margin</span> <span style="color: #aa2211">=</span> <span class="n">QApplication</span><span style="color: #aa2211">::</span><span class="n">style</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">pixelMetric</span><span class="p">(</span><span class="n">QStyle</span><span style="color: #aa2211">::</span><span class="n">PM_ButtonMargin</span><span class="p">,</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">  <span class="n">margin</span> <span style="color: #aa2211">=</span> <span class="n">qMax</span><span class="p">(</span><span class="n">qMin</span><span class="p">(</span><span class="n">margin</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span><span class="p">,</span> <span style="color: #601200">3</span><span class="p">),</span> <span style="color: #601200">3</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Note to self: Check why margin is limited to 3.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R353 KCalc</div></div></div><br /><div><strong>BRANCH</strong><div><div>compiler-warnings (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17901">https://phabricator.kde.org/D17901</a></div></div><br /><div><strong>To: </strong>gassaf, cfeck, teran<br /><strong>Cc: </strong>cfeck, kde-utils-devel<br /></div>