<table><tr><td style="">sitter added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13876">View Revision</a></tr></table><br /><div><div><p>Getting there :)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13876#inline-75817">View Inline</a><span style="color: #4b4d51; font-weight: bold;">widgetEvents.cpp:190</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">QLatin1Char</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">'\n'</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">m_focus</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">file</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">humanReadableSize</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_focus</span><span style="color: #aa2211">-></span><span class="n">file</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">isFolder</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">int</span> <span class="n">files</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span style="color: #aa4000">const</span> <span class="n">Folder</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">m_focus</span><span style="color: #aa2211">-></span><span class="n">file</span><span class="p">())</span><span style="color: #aa2211">-></span><span class="n">children</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">const</span> <span class="n">uint</span> <span class="n">percent</span> <span style="color: #aa2211">=</span> <span class="n">uint</span><span class="p">((</span><span style="color: #601200">100</span> <span style="color: #aa2211">*</span> <span class="n">files</span><span class="p">)</span> <span style="color: #aa2211">/</span> <span class="p">(</span><span style="color: #aa4000">double</span><span class="p">)</span><span class="n">m_tree</span><span style="color: #aa2211">-></span><span class="n">children</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">string</span> <span style="color: #aa2211">+=</span> <span class="n">QLatin1Char</span><span class="p">(</span><span style="color: #766510">'\n'</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">string</span> <span style="color: #aa2211">+=</span> <span class="n">i18np</span><span class="p">(</span><span style="color: #766510">"File: %1"</span><span class="p">,</span> <span style="color: #766510">"Files: %1"</span><span class="p">,</span> <span class="n">files</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">percent</span> <span style="color: #aa2211">></span> <span style="color: #601200">0</span><span class="p">)</span> <span class="n">string</span> <span style="color: #aa2211">+=</span> <span class="n">QString</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">" (%1%)"</span><span class="p">)).</span><span class="n">arg</span><span class="p">(</span><span class="n">percent</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">const</span> <span class="n">QUrl</span> <span class="n">url</span> <span style="color: #aa2211">=</span> <span class="n">Widget</span><span style="color: #aa2211">::</span><span class="n">url</span><span class="p">(</span><span class="n">m_focus</span><span style="color: #aa2211">-></span><span class="n">file</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_focus</span> <span style="color: #aa2211">==</span> <span class="n">m_rootSegment</span> <span style="color: #aa2211">&&</span> <span class="n">url</span> <span style="color: #aa2211">!=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">upUrl</span><span class="p">(</span><span class="n">url</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">string</span> <span style="color: #aa2211">+=</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"</span><span style="color: #bb6622">\n</span><span style="color: #766510">Click to go up to parent directory"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">m_focus</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span class="n"><span class="bright">m_rootSegment</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span class="n"><span class="bright">url</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">!=</span></span><span class="bright"> </span><span class="n"><span class="bright">KIO</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">upUrl</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">url</span></span><span class="bright"></span><span class="p"><span class="bright">))</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span class="n"><span class="bright">string</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+=</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"</span></span><span class="bright"></span><span style="color: #bb6622"><span class="bright">\n</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">Click to go up to parent directory"</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"> </span><span class="p"><span class="bright">}</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You could probably move the <tt style="background: #ebebeb; font-size: 13px;">\n</tt> out of the i18n call, and prepend it always. It doesn't need localization and it being not mid-string seems like something that can easily get lost when translating.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13876#inline-75818">View Inline</a><span style="color: #4b4d51; font-weight: bold;">summaryWidget.cpp:148</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">Folder</span> <span style="color: #aa2211">*</span><span class="n">tree</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">Folder</span><span class="p">(</span><span class="n">disk</span><span class="p">.</span><span class="n">mount</span><span class="p">.</span><span class="n">toUtf8</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">tree</span><span style="color: #aa2211">-></span><span class="n">append</span><span class="p">(</span><span class="n">free</span><span class="p">,</span> <span class="n">disk</span><span class="p">.</span><span class="n">free</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">tree</span><span style="color: #aa2211">-></span><span class="n">append</span><span class="p">(</span><span class="n">used</span><span class="p">,</span> <span class="n">disk</span><span class="p">.</span><span class="n">used</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">tree</span><span style="color: #aa2211">-></span><span class="n">append</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"</span>free<span class="bright">"</span></span><span class="p">,</span> <span class="n">disk</span><span class="p">.</span><span class="n">free</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">tree</span><span style="color: #aa2211">-></span><span class="n">append</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"</span>used<span class="bright">"</span></span><span class="p">,</span> <span class="n">disk</span><span class="p">.</span><span class="n">used</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Doesn't this undo some of the i18n in the original code?</p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13876">https://phabricator.kde.org/D13876</a></div></div><br /><div><strong>To: </strong>andrewc, sandsmark, sitter<br /><strong>Cc: </strong>kde-utils-devel<br /></div>