<table><tr><td style="">arojas added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6826" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D6826#128634" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D6826#128634</a>, <a href="https://phabricator.kde.org/p/wbauer/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@wbauer</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Hm, doesn't build here:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">[ 28%] Building CXX object CMakeFiles/kfloppy.dir/floppy.cpp.o
In file included from /usr/include/kcompletion.h:26:0,
                 from /usr/include/kcombobox.h:27,
                 from /home/wolfi/projects/KFloppy/floppy.cpp:48:
/usr/include/kshortcut.h: In function 'uint qHash(const KShortcut&)':
/usr/include/kshortcut.h:248:34: error: call of overloaded 'qHash(int)' is ambiguous
     return qHash(key.primary()[0]) + qHash(key.primary()[1]);
                                  ^</pre></div></div>
</blockquote>

<p>That doesn't look related to this change, does it build for you without the patch? Builds fine here with Qt 5.9.1, GCC 7.1.1</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R357 KFloppy</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6826" rel="noreferrer">https://phabricator.kde.org/D6826</a></div></div><br /><div><strong>To: </strong>arojas, wbauer<br /><strong>Cc: </strong>kde-utils-devel<br /></div>