<table><tr><td style="">elvisangelaccio added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5990" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Also, please let me know if you think I should reduce the #ifdefs to the strict minimum in main.cpp . A priori none of them is required, even the event filter could be installed as-is on all supported platforms if you don't mind invoking such a filter for nothing.</p></blockquote>
<p>Yes, the less the ifdefs the better. So, the <tt style="background: #ebebeb; font-size: 13px;">QFileOpenEvent</tt> event won't be sent on non-mac platforms?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5990#inline-24557" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:329-330</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#ifdef Q_OS_MACOS</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">volatile</span> <span style="color: #aa4000">const</span> <span class="n">OpenFileEventHandler</span> <span style="color: #aa2211">*</span><span class="n">openFileEventHandler</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">OpenFileEventHandler</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">application</span><span class="p">,</span> <span class="n">window</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Q_UNUSED</span><span class="p">(</span><span class="n">openFileEventHandler</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// we don't provide a fullscreen mode</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">While <tt style="background: #ebebeb; font-size: 13px;">volatile</tt>? Also, couldn't we just use:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">new OpenFileEventHandler(&application, window);</pre></div>
<p style="padding: 0; margin: 8px;">this way we don't need Q_UNUSED, no?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5990#inline-24555" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:331</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Q_UNUSED</span><span class="p">(</span><span class="n">openFileEventHandler</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// we don't provide a fullscreen mode</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">window</span><span style="color: #aa2211">-></span><span class="n">setWindowFlags</span><span class="p">(</span><span class="n">window</span><span style="color: #aa2211">-></span><span class="n">windowFlags</span><span class="p">()</span> <span style="color: #aa2211">&</span> <span style="color: #aa2211">~</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">WindowFullscreenButtonHint</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please replace "we" with "MacOS"</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5990#inline-24556" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:332</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// we don't provide a fullscreen mode</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">window</span><span style="color: #aa2211">-></span><span class="n">setWindowFlags</span><span class="p">(</span><span class="n">window</span><span style="color: #aa2211">-></span><span class="n">windowFlags</span><span class="p">()</span> <span style="color: #aa2211">&</span> <span style="color: #aa2211">~</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">WindowFullscreenButtonHint</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#endif</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">That's the only thing that really needs an ifdef, right?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5990#inline-24553" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pluginmanager.cpp:273</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// Step 2: ldd the libarchive plugin to figure out the absolute libarchive path.</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QProcess</span> <span class="n">ldd</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#ifdef Q_OS_MACOS</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please rename this variable, since it's not only about "ldd" anymore.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5990#inline-24554" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pluginmanager.cpp:274-280</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#ifdef Q_OS_MACOS</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QRegularExpression</span> <span style="color: #004012">regex</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"/.*/libarchive.*.dylib"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ldd</span><span class="p">.</span><span class="n">start</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"otool"</span><span class="p">),</span> <span class="p">{</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"-L"</span><span class="p">),</span> <span class="n">pluginPath</span><span class="p">});</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#else</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QRegularExpression</span> <span style="color: #004012">regex</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"/.*/libarchive.so"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">ldd</span><span class="p">.</span><span class="n">start</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"ldd"</span><span class="p">),</span> <span class="p">{</span><span class="n">pluginPath</span><span class="p">});</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#endif</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This ifdef could go away, use <tt style="background: #ebebeb; font-size: 13px;">QStandardPaths::findExecutable()</tt> to look for "otool" and use a regex that matches both types of path.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R36 Ark</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5990" rel="noreferrer">https://phabricator.kde.org/D5990</a></div></div><br /><div><strong>To: </strong>rjvbb, Ark, KDE Applications<br /><strong>Cc: </strong>elvisangelaccio, kde-utils-devel, kde-mac, tctara<br /></div>