<table><tr><td style="">elvisangelaccio created this revision.<br />Restricted Application added subscribers: Ark, kde-utils-devel.<br />Restricted Application added a project: Ark.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5100" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>libzip installs <tt style="background: #ebebeb; font-size: 13px;">zipconf.h</tt> in <tt style="background: #ebebeb; font-size: 13px;">$prefix/$libdir/libzip/include/</tt>. Some<br />
systems (e.g. archlinux) symlinks this file under <tt style="background: #ebebeb; font-size: 13px;">$prefix/$libdir/include</tt><br />
for compatibility reasons, but cmake fails on systems that do not (e.g.<br />
flatpak). Since libzip supports pkg-config, we can just query pkg-config<br />
which gives us the proper path we are looking for.</p>
<p>This breaks the Applications dependency freeze, but it's an important<br />
fix so it should go in.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>ark master flatpak now can build the new libzip plugin.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R36 Ark</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5100" rel="noreferrer">https://phabricator.kde.org/D5100</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>cmake/modules/FindLibZip.cmake</div></div></div><br /><div><strong>To: </strong>elvisangelaccio, rthomsen<br /><strong>Cc: </strong>kde-utils-devel, Ark, tctara<br /></div>