<table><tr><td style="">elvisangelaccio created this revision.<br />elvisangelaccio added a reviewer: rthomsen.<br />Restricted Application added a subscriber: kde-utils-devel.<br />Restricted Application added a project: Ark.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3873" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The ExtractionDialog only needs to know if it should enable the 'Extraction<br />
into subfolder' groupbox, not why. We rename <tt style="background: #ebebeb; font-size: 13px;">setIsSingleFolder()</tt> to<br />
<tt style="background: #ebebeb; font-size: 13px;">setExtractToSubfolder()</tt> and we call it with<br />
<tt style="background: #ebebeb; font-size: 13px;">archive->hasMultipleTopLevelEntries()</tt> as argument.<br />
This fixes the regression with single-file archives.</p>
<p>CCBUG: 374253</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Open a single-file archive, open the extraction dialog. The 'Extraction into<br />
subfolder' groupbox is now unchecked.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R36 Ark</div></div></div><br /><div><strong>BRANCH</strong><div><div>single-file-no-subfolder</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3873" rel="noreferrer">https://phabricator.kde.org/D3873</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>app/batchextract.cpp<br />
kerfuffle/extractiondialog.cpp<br />
kerfuffle/extractiondialog.h<br />
part/part.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>elvisangelaccio, rthomsen<br /><strong>Cc: </strong>kde-utils-devel, tctara<br /></div>