<table><tr><td style="">elvisangelaccio created this revision.<br />elvisangelaccio added a reviewer: rthomsen.<br />Restricted Application added a subscriber: kde-utils-devel.<br />Restricted Application added a project: Ark.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3039" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Currently they both are QHash typedefs, which means they are the same thing for the<br />
compiler. For this reason if we pass a CompressionOptions object where an<br />
ExtractionOptions object was expected, the code compiles file even if this is a<br />
major design flaw. Currently we have at least a couple of such bugs, so let's fix<br />
them all by using proper types.</p>

<p>While at it:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">The default value for the <tt style="background: #ebebeb; font-size: 13px;">PreservePaths</tt> option was false, now is true because it's the more common case.</li>
<li class="remarkup-list-item">The <tt style="background: #ebebeb; font-size: 13px;">RemoveRootNode</tt> option was redundant, it was only used together with the <tt style="background: #ebebeb; font-size: 13px;">DragAndDrop</tt> one.</li>
<li class="remarkup-list-item">The <tt style="background: #ebebeb; font-size: 13px;">FollowExtractionDialogSettings</tt> was only set but never read, so we can drop it.</li>
</ul></div></div><br /><div><strong>TEST PLAN</strong><div><p>Tests still pass.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rARK Ark</div></div></div><br /><div><strong>BRANCH</strong><div><div>options</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3039" rel="noreferrer">https://phabricator.kde.org/D3039</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/kerfuffle/adddialogtest.cpp<br />
autotests/kerfuffle/addtest.cpp<br />
autotests/kerfuffle/copytest.cpp<br />
autotests/kerfuffle/extracttest.cpp<br />
autotests/kerfuffle/jobstest.cpp<br />
autotests/kerfuffle/jsonarchiveinterface.cpp<br />
autotests/kerfuffle/movetest.cpp<br />
autotests/plugins/cliunarchiverplugin/cliunarchivertest.cpp<br />
kerfuffle/CMakeLists.txt<br />
kerfuffle/adddialog.h<br />
kerfuffle/addtoarchive.cpp<br />
kerfuffle/archive_kerfuffle.cpp<br />
kerfuffle/archive_kerfuffle.h<br />
kerfuffle/cliinterface.cpp<br />
kerfuffle/cliinterface.h<br />
kerfuffle/compressionoptionswidget.cpp<br />
kerfuffle/compressionoptionswidget.h<br />
kerfuffle/jobs.cpp<br />
kerfuffle/options.cpp<br />
kerfuffle/options.h<br />
part/archivemodel.cpp<br />
part/archivemodel.h<br />
part/part.cpp<br />
part/part.h<br />
plugins/cliunarchiverplugin/cliplugin.cpp<br />
plugins/clizipplugin/cliplugin.cpp<br />
plugins/libarchive/libarchiveplugin.cpp<br />
plugins/libarchive/readwritelibarchiveplugin.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>elvisangelaccio, rthomsen<br /><strong>Cc: </strong>kde-utils-devel, tctara<br /></div>