<table><tr><td style="">elvisangelaccio added a comment.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2120" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>The dialog works fine, I only have minor comments!</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2120#inline-8237" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:17</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> mimetypetest.cpp
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> LINK_LIBRARIES kerfuffle Qt5::Test
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> LINK_LIBRARIES kerfuffle Qt5::Test<span class="bright"> KF5::KIOFileWidgets</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> NAME_PREFIX kerfuffle-)
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Think links all the executables to KioFileWidgets. This could result in a slower build.<br />
Please add a dedicated <tt style="background: #ebebeb; font-size: 13px;">ecm_add_test()</tt> below for this new test.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2120#inline-8239" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">adddialog.cpp:61</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">QPushButton</span> <span style="color: #aa2211">*</span><span class="n">optionsButton</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QPushButton</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Advanced Options"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">optionsButton</span><span style="color: #aa2211">-></span><span class="n">setSizePolicy</span><span class="p">(</span><span class="n">QSizePolicy</span><span style="color: #aa2211">::</span><span class="n">Fixed</span><span class="p">,</span> <span class="n">QSizePolicy</span><span style="color: #aa2211">::</span><span class="n">Fixed</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe this button could have the "option" icon? (the one used also in the Settings menu)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2120#inline-8240" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">adddialog.cpp:70</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">m_fileWidget</span><span style="color: #aa2211">-></span><span class="n">okButton</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Add"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">m_fileWidget</span><span style="color: #aa2211">-></span><span class="n">okButton</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">show</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">i18nc("@action:button", "Add")</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2120#inline-8242" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">adddialog.cpp:103</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">CompressionOptionsWidget</span> <span style="color: #aa2211">*</span><span class="n">optionsWidget</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">CompressionOptionsWidget</span><span class="p">(</span><span class="n">m_mimeType</span><span class="p">,</span> <span class="n">m_compOptions</span><span class="p">,</span> <span class="n">optionsDialog</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">optionsWidget</span><span style="color: #aa2211">-></span><span class="n">setMinimumWidth</span><span class="p">(</span><span style="color: #601200">300</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">optionsWidget</span><span style="color: #aa2211">-></span><span class="n">setEncryptionVisible</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is this really necessary?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2120#inline-8243" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">adddialog.cpp:120</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">optionsDialog</span><span style="color: #aa2211">-></span><span class="n">deleteLater</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">optionsWidget</span><span style="color: #aa2211">-></span><span class="n">deleteLater</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="p">});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">optionsWidget</tt> is a child of <tt style="background: #ebebeb; font-size: 13px;">optionsDialog</tt>, no need to delete it manually.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2120#inline-8241" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">adddialog.h:64</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="n">public</span> <span style="color: #a0a000">slots</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">void</span> <span class="n">slotOpenOptions</span><span class="p">(</span><span style="color: #aa4000">bool</span> <span class="n">checked</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">checked</tt> is not used, we can drop it (the <tt style="background: #ebebeb; font-size: 13px;">connect()</tt> will work fine).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2120#inline-8244" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">compressionoptionswidget.h:47</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">const</span> <span class="n">CompressionOptions</span> <span style="color: #aa2211">&</span><span class="n">opts</span> <span style="color: #aa2211">=</span> <span class="n">QHash</span><span style="color: #aa2211"><</span><span class="n">QString</span><span class="p">,</span> <span class="n">QVariant</span><span style="color: #aa2211">></span><span class="p">(),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">QWidget</span> <span style="color: #aa2211">*</span><span class="n">parent</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">int</span> <span class="n">compressionLevel</span><span class="p">()</span> <span style="color: #aa4000">const</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">Q_NULLPTR</tt> instead of 0</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2120#inline-8245" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">createdialog.cpp:96-97</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">optionsWidget</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">CompressionOptionsWidget</span><span class="p">(</span><span class="n">currentMimeType</span><span class="p">(),</span> <span class="n">QHash</span><span style="color: #aa2211"><</span><span class="n">QString</span><span class="p">,</span> <span class="n">QVariant</span><span style="color: #aa2211">></span><span class="p">(),</span> <span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">m_ui</span><span style="color: #aa2211">-></span><span class="n">vlayout</span><span style="color: #aa2211">-></span><span class="n">insertWidget</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">,</span> <span class="n">optionsWidget</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can't you add this widget in <tt style="background: #ebebeb; font-size: 13px;">createdialog.ui</tt>? You can call <tt style="background: #ebebeb; font-size: 13px;">setMimeType()</tt> instead of passing the mimetype to the constructor.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2120#inline-8246" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">part.cpp:1244</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">QStringList</span></span><span class="bright"> </span><span class="n"><span class="bright">filesToAdd</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">QFileDialog</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">getOpenFileNames</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">widget</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span><span class="bright"> </span><span class="n"><span class="bright">i18nc</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"@title:window"</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"Add Files"</span></span><span class="bright"></span><span class="p"><span class="bright">));</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span class="n"><span class="bright">slotAdd</span>File<span class="bright">s</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">filesToAdd</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span class="n"><span class="bright">QPointer</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span class="n"><span class="bright">AddDialog</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="n"><span class="bright">dlg</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">new</span></span><span class="bright"> </span><span class="n"><span class="bright">AddDialog</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">widget</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="bright"> </span><span class="n"><span class="bright">i18nc</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"@title:window"</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"Add Files"</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"> </span><span class="n"><span class="bright">QUrl</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromLocal</span>File<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QDir</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">homePath</span></span><span class="bright"></span><span class="p"><span class="bright">()),</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The name of the actions and the title of the dialog are not consistent:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Action in the menu => <tt style="background: #ebebeb; font-size: 13px;">Add File...</tt></li>
<li class="remarkup-list-item">Action in the toolbar => <tt style="background: #ebebeb; font-size: 13px;">Add File</tt></li>
<li class="remarkup-list-item">Title of the dialog => <tt style="background: #ebebeb; font-size: 13px;">Add Files</tt></li>
</ul>
<p style="padding: 0; margin: 8px;">Not sure what should we do, though...</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rARK Ark</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2120" rel="noreferrer">https://phabricator.kde.org/D2120</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>rthomsen, elvisangelaccio<br /><strong>Cc: </strong>kde-utils-devel, tctara<br /></div>