<table><tr><td style="">rthomsen requested changes to this revision.<br />rthomsen added a comment.<br />This revision now requires changes to proceed.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1725" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>See inline comment.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1725#inline-6912" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">archive_kerfuffle.cpp:71-75</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">parent</span><span class="p">,</span> <span class="n">QMimeDatabase</span><span class="p">().</span><span class="n">mimeTypeForName</span><span class="p">(</span><span class="n">mimeType</span><span class="p">).</span><span class="n">parentMimeTypes</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">metaData</span><span class="p">.</span><span class="n">mimeTypes</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">parent</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                    <span style="color: #aa4000">return</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Instead of iterating over the parent mimetypes, you can iterate over metaData.mimeTypes() and then use QMimeType::inherits() to check if mimeType inherits each of those. The result should be the same, but the code might be easier to understand?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rARK Ark</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1725" rel="noreferrer">https://phabricator.kde.org/D1725</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>elvisangelaccio, rthomsen<br /><strong>Cc: </strong>kde-utils-devel, tctara<br /></div>