<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126139/">https://git.reviewboard.kde.org/r/126139/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">About the translations: you need to change your Messages.sh file so that it can find all the translations.
You can try to follow the steps here on the current code and after your patches:
http://tsdgeos.blogspot.com/2010/08/how-to-run-messagessh-file-to-create.html</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With the new code only 2 messages are extracted.
You can update the two lines of Messages.sh with:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">$<span style="color: #19177C">EXTRACTRC</span> $(<span style="border: 1px solid #FF0000">find</span> <span style="border: 1px solid #FF0000">.</span> <span style="border: 1px solid #FF0000">-name</span> <span style="color: #BA2121">'*.rc'</span> <span style="border: 1px solid #FF0000">-o</span> <span style="border: 1px solid #FF0000">-name</span> <span style="color: #BA2121">'*.ui'</span>) >> rc.cpp
$<span style="color: #19177C">XGETTEXT</span> $(<span style="border: 1px solid #FF0000">find</span> <span style="border: 1px solid #FF0000">.</span> <span style="border: 1px solid #FF0000">-name</span> <span style="color: #BA2121">'*.cpp'</span>) -o $<span style="color: #19177C">podir</span>/kdf.pot
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">so basically with the proper list of files.
I can push a commit to fix that afterwards or you can do it directly.</p></pre>
<br />
<p>- Luigi Toscano</p>
<br />
<p>On marzo 31st, 2016, 8:52 p.m. CEST, Yoann Laissus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Yoann Laissus.</div>
<p style="color: grey;"><i>Updated Mar. 31, 2016, 8:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdf
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A port of KDiskFree to KF5 / Qt5, without KDE4LibsSupport.
Please let me know if everything is right, especially about the KMenu / KDialog migration.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">About the desktop files, are my changes corrects ? And what about the KCM one ?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All features of KDiskFree tested.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ad591e70cbbb6d10fdf362f68bfa3764646ab662)</span></li>
<li>CTestConfig.cmake <span style="color: grey">(57ed0aa82850e54643b52b907208ea7ded05ac84)</span></li>
<li>desktop/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>disklist.h <span style="color: grey">(0c972eeebc1a669a8943811303477e573307dabf)</span></li>
<li>disklist.cpp <span style="color: grey">(12e12353748bbc46db013b90b5292c0cfa8f6c2f)</span></li>
<li>disks.h <span style="color: grey">(e5de94e843683d38dfee5d74bf7873de15ec6d3a)</span></li>
<li>disks.cpp <span style="color: grey">(83f9729021fd24e2a19d333f5ef1503d7760e684)</span></li>
<li>doc/app/CMakeLists.txt <span style="color: grey">(44bb820a89ee24d2dcd0bdf825cb64f8f4cc831e)</span></li>
<li>doc/kcontrol/CMakeLists.txt <span style="color: grey">(b0face2673997aad2193ea716634b7bad0c426ac)</span></li>
<li>kcmdf.cpp <span style="color: grey">(36c379ec499f92bb3e1e26c79fba96ef410a6dda)</span></li>
<li>kcmdf.desktop <span style="color: grey">(5e17fcc7eeb5ab9f1cd4cb759c4ee86a31526080)</span></li>
<li>kcmdf.h <span style="color: grey">(1efa465f6e8fd028dbd2f0a95128849c657ca417)</span></li>
<li>kconftest.cpp <span style="color: grey">(05d09d372a09f72be8134c77f956919d24182c9c)</span></li>
<li>kdf.h <span style="color: grey">(466a7e60a6f43c8f4339e0051ec4aa04f10dab59)</span></li>
<li>kdf.cpp <span style="color: grey">(c1f8aa64526623a60b37c65319c6e933d66d3e35)</span></li>
<li>kdf.desktop <span style="color: grey">()</span></li>
<li>kdfconfig.h <span style="color: grey">(8cad04a176cf1f083c61761487ea425d2881ad08)</span></li>
<li>kdfconfig.cpp <span style="color: grey">(f6fe25807d04db6b258f4ce0eb7f53e86adb522d)</span></li>
<li>kdfconfig.ui <span style="color: grey">()</span></li>
<li>kdfitemdelegate.h <span style="color: grey">(1d5f25f1fd733b544966567ed8f211b3be048bca)</span></li>
<li>kdfitemdelegate.cpp <span style="color: grey">(7c2eac559e7d64cfe13181cbd034b26a25133670)</span></li>
<li>kdfsortproxymodel.h <span style="color: grey">(207bbda0378b1afa4e8939304cfb38206038a0af)</span></li>
<li>kdfsortproxymodel.cpp <span style="color: grey">()</span></li>
<li>kdfui.rc <span style="color: grey">()</span></li>
<li>kdfutil.h <span style="color: grey">()</span></li>
<li>kdfwidget.h <span style="color: grey">(d611a477253189cb9f785a81ac4ab56e53828574)</span></li>
<li>kdfwidget.cpp <span style="color: grey">(9312365631e6e766e5700c57ec17b1064073ed67)</span></li>
<li>kwikdisk.cpp <span style="color: grey">(713ebfc056c82a4101b736f46b4803e75db7e7e0)</span></li>
<li>kwikdisk.desktop <span style="color: grey">()</span></li>
<li>kwikdisk.h <span style="color: grey">(39582d09f00bdaef3b0d61cc61f852cba0d8272c)</span></li>
<li>mntconfig.h <span style="color: grey">(ecb07f19eeef5b398f2e366bb2792cda94c35f69)</span></li>
<li>mntconfig.cpp <span style="color: grey">(33cd92a9b3325dca4d4b2038b904f9ee8d16e71f)</span></li>
<li>mntconfig.ui <span style="color: grey">(39cb679a2dff3e47f8cb3a29a766c941e1fe3035)</span></li>
<li>optiondialog.h <span style="color: grey">(e08f1168dc89ff24fff17cdfe600ed3c655646cd)</span></li>
<li>optiondialog.cpp <span style="color: grey">(97d5e3fb75351abeb184064cae3578bdb39822b1)</span></li>
<li>pics/CMakeLists.txt <span style="color: grey">(7affd27ee45de94f71ab2af5cab74f1a54bb9400)</span></li>
<li>pics/hi128-app-kdf.png <span style="color: grey">()</span></li>
<li>pics/hi128-app-kwikdisk.png <span style="color: grey">()</span></li>
<li>pics/hi16-app-kdf.png <span style="color: grey">()</span></li>
<li>pics/hi16-app-kwikdisk.png <span style="color: grey">()</span></li>
<li>pics/hi22-app-kdf.png <span style="color: grey">()</span></li>
<li>pics/hi22-app-kwikdisk.png <span style="color: grey">()</span></li>
<li>pics/hi32-app-kdf.png <span style="color: grey">()</span></li>
<li>pics/hi32-app-kwikdisk.png <span style="color: grey">()</span></li>
<li>pics/hi48-app-kdf.png <span style="color: grey">()</span></li>
<li>pics/hi48-app-kwikdisk.png <span style="color: grey">()</span></li>
<li>pics/hi64-app-kdf.png <span style="color: grey">()</span></li>
<li>pics/hi64-app-kwikdisk.png <span style="color: grey">()</span></li>
<li>pics/ox16-app-kcmdf.png <span style="color: grey">()</span></li>
<li>pics/ox22-app-kcmdf.png <span style="color: grey">()</span></li>
<li>pics/ox32-app-kcmdf.png <span style="color: grey">()</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>stdoption.h <span style="color: grey">(78527c6db976993155307a0fcfa7998e07fd6892)</span></li>
<li>stdoption.cpp <span style="color: grey">(fce7b894164cf5e8a0fde80353661919a2d5d045)</span></li>
<li>unix_outputs/df-g.hpux <span style="color: grey">(8d1e8221d826d9db307c0dcd4ec18b801c22d8aa)</span></li>
<li>unix_outputs/df-k.digital <span style="color: grey">(ae61ca50228998b1713e90733e29f537f9f84a6e)</span></li>
<li>unix_outputs/df-k.hpux <span style="color: grey">(3e9a3866e282689148a6cbe2dc12ec18e18ee77b)</span></li>
<li>unix_outputs/df.man.hpux <span style="color: grey">(969320d9ce323e9d46e1319d0b56d2f8aea3b8e1)</span></li>
<li>unix_outputs/etcfstab.digital <span style="color: grey">(1bfcc0efaa2195bb0cd29f5e423f22c116f62484)</span></li>
<li>unix_outputs/etcfstab.hpux <span style="color: grey">(af333b11d8f3bd3f51f1e3a11ba70d63eeea2478)</span></li>
<li>unix_outputs/unix-defines.txt <span style="color: grey">(75a28467c58f3fcde45701a28c6b7c54c74154c6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126139/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>