<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127003/">https://git.reviewboard.kde.org/r/127003/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On février 7th, 2016, 6:09 après-midi UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At this point, I would strongly suggest to use qCDebug instead to not lose the categorized logging.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Currently, KDF still uses Qt4 / KDE 4 libs so qCDebug isn't available.
This patch was just to ease the review process for the port to KF5 / Qt5 by making a more reasonable diff. (#126139)
Once the port achieved, the next step will be to port to qCDebug.</p></pre>
<br />
<p>- Yoann</p>
<br />
<p>On février 8th, 2016, 12:11 après-midi UTC, Yoann Laissus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Yoann Laissus.</div>
<p style="color: grey;"><i>Updated fév. 8, 2016, 12:11 après-midi</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdf
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KF5 port : Replace all kDebug by their qDebug equivalent.
It also get rid of a legacy test class which still use Qt3Support.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's the first step before the real port : see #126139</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>disklist.cpp <span style="color: grey">(12e12353748bbc46db013b90b5292c0cfa8f6c2f)</span></li>
<li>disks.cpp <span style="color: grey">(83f9729021fd24e2a19d333f5ef1503d7760e684)</span></li>
<li>kconftest.cpp <span style="color: grey">(05d09d372a09f72be8134c77f956919d24182c9c)</span></li>
<li>kdf.cpp <span style="color: grey">(c1f8aa64526623a60b37c65319c6e933d66d3e35)</span></li>
<li>kdfwidget.cpp <span style="color: grey">(9312365631e6e766e5700c57ec17b1064073ed67)</span></li>
<li>kwikdisk.cpp <span style="color: grey">(713ebfc056c82a4101b736f46b4803e75db7e7e0)</span></li>
<li>mntconfig.cpp <span style="color: grey">(33cd92a9b3325dca4d4b2038b904f9ee8d16e71f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127003/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>