<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/106294/">https://git.reviewboard.kde.org/r/106294/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've been working on a new version of this patch. The lsar output is now parsed using Qt5 json support.
The plugin is currently able to extract RAR archives. Extraction of encrypted RAR archives is not yet available though.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You can find it in the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">feature/unarchiver</code> upstream branch. Feel free to test it :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks to the authours of the original patch and please, discard this review request.</p></pre>
<br />
<p>- Elvis Angelaccio</p>
<br />
<p>On September 1st, 2012, 3:30 p.m. UTC, Andrius Štikonas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Andrius Štikonas.</div>
<p style="color: grey;"><i>Updated Sept. 1, 2012, 3:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is based on https://svn.reviewboard.kde.org/r/6730/ (Luke Shumaker <LukeShu@sbcglobal.net>)
This patch will allow Ark to use The Unarchiver command line utilities
(unar/lsar) to operate on RAR files, particularly RARv3.
Now, Ark selects which plugin to use based on MIME type, and the
X-KDE-Priority of the plugin. Unfortunately, there is currently no
mechanism for a fallback, say one plugin doesn't work, to use
another. So, for right now users wishing to use Ark with RAR files
must either choose between clirarplugin (which either uses unrar-free
or unrar-nonfree), and cliunarchiverplugin (which uses unar and lsar),
with Ark not being able to just detect which is installed.
To change the X-KDE-Priority, you just need to edit some .desktop
files. In the source they are
`ark/plugins/*plugin/kerfuffle_*.desktop', which on many systems get
installed to `/usr/share/kde4/services/kerfuffle_*.desktop'. The
plugin with the highest priority is used. The clirarplugin has a
defualt priority of 120, I've given cliunarchiverplugin a priority of
150. This is probably best set by the package maintainer of an OS;
for example, many systems will prefer unrar-nonfree, but I created
this with Parabola in mind, on which unrar-nonfree does not exist, and
this is the only way that RARv3 files will be opened.
Honestly though, this setup sucks, because unrar-free and unar/lsar
both have their own stengths (basically, unar/lsar suck, but
unrar-free doesn't work on RARv3), and the ideal setup would be to use
unrar-free in most cases, but to fall back to unar/lsar for RARv3
files that unrar-free can't handle. Actually, I guess the ideal setup
would be to make unar/lsar suck less, or to add RARv3 to rar-free.
=== Known Bugs ===
The program should be able to look at which version of RAR the file
is, but currently doesn't. (I mean just within lsar) This is simply
because I don't know which field to look at.
=== ChangeLog (Luke Shumaker <LukeShu@sbcglobal.net>)===
00 - Initial patch
01 - Enable clirar, but make cliunarchiver higher priority
02 - Reformat patch
03 - Reformat patch so that ReviewBoard recognizes it
=== Changelog (Andrius Štikonas <stikonas@gmail.com>) ===
04 - new versions of unar can extract password protected files and have
the ability to extract single files from the archive.
Make the patch compile with latest git versions of ark.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/cliunarchiverplugin/kerfuffle_cliunarchiver.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/cliunarchiverplugin/cliplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/CMakeLists.txt <span style="color: grey">(3619412)</span></li>
<li>plugins/cliunarchiverplugin/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/106294/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>