<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124468/">https://git.reviewboard.kde.org/r/124468/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On luglio 26th, 2015, 8:14 a.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Definitely as useful feature (for those people who use archives with comments).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I wonder, though: Couldn't the comment just be shown in the info panel on the right as long as no file within the archive is selected, instead of in a popup?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1, this would also simplify the patch (no need to add a new action).</p></pre>
<br />
<p>- Elvis</p>
<br />
<p>On luglio 25th, 2015, 11:20 p.m. UTC, Ragnar Thomsen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Utils, KDE Usability, Elvis Angelaccio, and Raphael Kubo da Costa.</div>
<div>By Ragnar Thomsen.</div>
<p style="color: grey;"><i>Updated Lug. 25, 2015, 11:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=328790">328790</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add support for reading comments in CLI-based plugins such as rar and zip. The comment is parsed from the output of ListJob. If a comment is available, a dismissible KMessagewidget is shown with a "Show comment" button. The comment can also be accessed from the Action menu.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Support is added to clirar, clizip and cli7z plugins. AFAIK the 7z-format doesn't support comments, but the cli7z-plugin supports reading comments in e.g. zip archives.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested opening zip and rar archives with comments.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kerfuffle/archive_kerfuffle.h <span style="color: grey">(f6fbbd8)</span></li>
<li>kerfuffle/archive_kerfuffle.cpp <span style="color: grey">(7b9990d)</span></li>
<li>kerfuffle/archiveinterface.h <span style="color: grey">(1aac2a4)</span></li>
<li>kerfuffle/cliinterface.h <span style="color: grey">(50c9e36)</span></li>
<li>kerfuffle/cliinterface.cpp <span style="color: grey">(2f5d607)</span></li>
<li>part/ark_part.rc <span style="color: grey">(da04d47)</span></li>
<li>part/part.h <span style="color: grey">(5098bd5)</span></li>
<li>part/part.cpp <span style="color: grey">(da26a5b)</span></li>
<li>plugins/cli7zplugin/cliplugin.cpp <span style="color: grey">(51480bc)</span></li>
<li>plugins/clirarplugin/cliplugin.cpp <span style="color: grey">(62d2078)</span></li>
<li>plugins/clizipplugin/cliplugin.cpp <span style="color: grey">(db8dcea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124468/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/df1f1b4f-cb74-4f9a-be85-0658ca6a8bbb__support-comments-1.png">KMessageWidget</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/136466f5-e757-4c85-a03e-7909a7e860e5__support-comments-2.png">Viewing a comment.</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/cce3359d-edf3-4984-9eaf-a193e944060e__support-comments-3.png">Show Comment menu item</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>