<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121997/">https://git.reviewboard.kde.org/r/121997/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated Lug. 16, 2015, 10:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Rebased against the new KF5-based master.
* Removed those unnecessary `virtual` keywords.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=165314">165314</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch implements the standard Configuration Dialog (i.e. using <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KConfigDialog</code>) in Ark, as one would expect from a KDE application.
This feature has been requested in more than one bug. I choosed to target bug 165314 since the others are more like "add the config dialog to implement the feature <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">foo</em>".</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The widgets showed in the config dialog are provided by the Ark <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Part</code> interface (just one widget for now). This should help to show the Ark settings in, for instance, Konqueror's config dialog. A similar approach is done in Kate and Cantor, from what I have seen.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't like very much the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">document-save</code> icon used for the Extraction page, but I couldn't find any better.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compile and run, then try to change some settings and check that they persist.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/mainwindow.h <span style="color: grey">(5dd7fb82e3f5a48c9bdbefcef2a83c3e990482ca)</span></li>
<li>app/mainwindow.cpp <span style="color: grey">(aee823174a0b731e125381be09181938cdb6dd7d)</span></li>
<li>kerfuffle/CMakeLists.txt <span style="color: grey">(8c56b4f46090c924f0848ad229b6a3779af1f1f3)</span></li>
<li>kerfuffle/ark.kcfg <span style="color: grey">(97d2086688698e96c429def089c50ff3cdbe4c4e)</span></li>
<li>kerfuffle/extractionsettings.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/extractionsettingspage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/extractionsettingspage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/previewsettings.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/previewsettingspage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/previewsettingspage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/settingspage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/settingspage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>part/interface.h <span style="color: grey">(40f590284502d23a2a4ffaa333bfd5b63e6ec773)</span></li>
<li>part/part.h <span style="color: grey">(5379b9fc1aaa4ce451c8b1745ca46ee78630b005)</span></li>
<li>part/part.cpp <span style="color: grey">(09fe1cbfcc7f4345fe12932055dcb041f50abb7b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121997/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/03/3dfe3110-4f46-4c14-9b19-79060577a4c9__extraction-settings.png">extraction-settings.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/8a1600b1-64a7-43fa-87e8-0c84e054d801__preview-settings1.png">preview-settings1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/f687f5ea-3f2e-48b0-b204-92e3fbdf23e7__preview-settings2.png">preview-settings2.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>