<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120783/">https://git.reviewboard.kde.org/r/120783/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Elvis Angelaccio.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When Ark is run from a terminal, the following warning is displayed on exit:
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">ark(6384)/kdeui (kdelibs) KXMLGUIClient::~KXMLGUIClient: 0x101cf80 deleted without having been removed from the factory first. This will leak standalone popupmenus and could lead to crashes.</code></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The warning is fixed by just removing the client from the KXMLGUIFactory, in the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Part</code> destructor.
A similar fix has been done in other apps, e.g. see <a href="https://projects.kde.org/projects/kde/applications/kate/repository/revisions/4c56004ebbc5b1edb2c94d358c623015f10a1a3d" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Kate</a>.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This was one of the two unrelated patches that were in this other <a href="https://git.reviewboard.kde.org/r/120216/" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">review</a>.
The other one <a href="http://quickgit.kde.org/?p=ark.git&a=commit&h=8fc15207c00aadeb3cee58ab68e443a7966291df" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">has been already committed</a> to the frameworks branch, so I guess we can ignore it for master.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compile and run Ark from Konsole. The warning is gone.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/part.cpp <span style="color: grey">(09fe1cbfcc7f4345fe12932055dcb041f50abb7b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120783/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>