<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119892/">https://git.reviewboard.kde.org/r/119892/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 29th, 2014, 9:30 vorm. UTC, <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks for your work on this feature - I think that many users would really appreciate this.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think that Emmanuel's idea to add write support to the kioslave might be worth considering. However, implementing the drop on an archive file which is not opened in the view (i.e., the archive kioslave is not active yet) might be more difficult then maybe?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would suggest to add David Faure as a reviewer to this request - maybe he has an idea what the best solution is.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A question concerning your proposed changes in Dolphin's source code: right now, when the user drops items on, e.g., a text file, this will be treated like a drop on the empty space in the view, i.e., the items will be copied/moved/linked to the directory which is shown in the view. With your patch, we would ask KonqOperations to drop the items on the text file, right? Will this result in an error message? I think that we should try to keep the current behavior in that situation, i.e., move/copy/link the dropped items in the directory that contains the text file where the items are dropped.</p></pre>
</blockquote>
<p>On September 4th, 2014, 7:20 vorm. UTC, <b>Arjun Ak</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Will this result in an error message?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No, the mimetype of the destination file is checked to see whether it is an archive supported by ark. If so an "Add to archive" option is added to the context menu. The rest of the options (copy/move/link/cancel) remains untouched.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Did you try how either option behaves? In particular whether copying "test1/foo.txt" onto "test2/bar.txt" will result in "test2/foo.txt" or "test2/bar.txt" having the contents of "test1/foo.txt"?</p></pre>
<br />
<p>- Thomas</p>
<br />
<p>On September 4th, 2014, 7:20 vorm. UTC, Arjun Ak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Base Apps, KDE Utils and David Faure.</div>
<div>By Arjun Ak.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2014, 7:20 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=338414">338414</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch implements the "Add to archive" option, which is shown when a user drags and drops files onto an existing archive. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See also:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
https://git.reviewboard.kde.org/r/119890<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
https://bugs.kde.org/show_bug.cgi?id=338414</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/views/dolphinview.cpp <span style="color: grey">(02b8815)</span></li>
<li>dolphin/src/views/draganddrophelper.cpp <span style="color: grey">(f8ae0ad)</span></li>
<li>lib/konq/konq_operations.cpp <span style="color: grey">(220a90a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119892/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>