<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110672/">https://git.reviewboard.kde.org/r/110672/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On agost 7th, 2014, 9:50 p.m. UTC, <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am sorry, but I had to revert this in commit 4429a4ebbb58f44e4c96603f6bc519da8c0ce5da because of the regressions it introduces. As I mentioned there, while this appears to work correctly for ZIP and LHA archives, it can fail for libarchive (e.g. tar archives) and RAR.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For example, if I open phonon-4.7.2.tar.xz, select declarative/abstractinitable.h, doc/BUGS, doc/IDEAS and phonon.pc.cmake and drag phonon.pc.cmake, I end up with "on.pc.cmake", "arative/abstractinitable.h", "IDEAS" and "BUGS". If I drag everything via declarative/abstractinitable.h, I end up with only "abstractinitable.h" (no directory structure) and "ake".</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Alim: I deeply apologize for the lack of response in this review request, I've just been busy with a lot of other projects in my paid and free time. If you send another patch that addresses these problems, or need to discuss them, I'll do my best to answer in a more timely manner.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Albert: Thank you again for the interest in committing these long-standing review requests and fixing these annoying bugs with a lot of votes, but please at least ping me first and/or do some testing before pushing.</p></pre>
</blockquote>
<p>On agost 7th, 2014, 9:55 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well when I added you to this review I was pinging you, you got a mail, consider yourself pinged.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also i did some testing, obviously not enough, sorry for that.</p></pre>
<br />
<p>- Albert</p>
<br />
<p>On agost 6th, 2014, 10:24 p.m. UTC, Alim Gokkaya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Utils, Albert Astals Cid and Raphael Kubo da Costa.</div>
<div>By Alim Gokkaya.</div>
<p style="color: grey;"><i>Updated ago. 6, 2014, 10:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch enables extracting multiple files using drag&drop by removing the code that singles the selection.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/archiveview.cpp <span style="color: grey">(6b9918d)</span></li>
<li>part/part.cpp <span style="color: grey">(b4ebcd2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110672/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>