<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117467/">https://git.reviewboard.kde.org/r/117467/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 21st, 2014, 9:32 p.m. UTC, <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you for the patch, but I don't understand how it is supposed to solve bug 245705 (it still happens if I apply the patch here). Even if it's unrelated to that bug, it's still unclear to me what problem it is trying to fix.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When you open invalid archive (like test.txt renamed to test.zip) the Ark tries to detect the archive type by using function KMimeType::findByNameAndContent(filename, buffer), but this function first detects file type name and if it detects *.zip it doesn't try to verify if the content rely matches archive type. So I have replaced the function with this KMimeType::findByContent(buffer), which wouldn't load invalid archive with invalid content. The problem with applying this patch is that it fixes an Ark library and not Ark itself, so I had to copy Ark's libraries to my system paths to make it run. It solves bug by forcing you to choose archive type (in popup window). If it does not work, another popup shows message about not being able to open an archive file and the main Ark window is left blank.</pre>
<br />
<p>- Ondřej</p>
<br />
<p>On April 10th, 2014, 7:59 a.m. UTC, Ondřej Záruba wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Ondřej Záruba.</div>
<p style="color: grey;"><i>Updated April 10, 2014, 7:59 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=245705">245705</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ark tests the archive type just by file name, which is not enough. This patch forces Ark to detect file type by its content.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kerfuffle/archive.cpp <span style="color: grey">(c2c5b18)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117467/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>