<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105427/">http://git.reviewboard.kde.org/r/105427/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 10th, 2013, 1:52 p.m. UTC, <b>Evan Teran</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I had to make some minor tweaks to the patch because my copy of the sources have changed since the patch was created. But I've not applied it :-) Looks good.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Michael, this has been committed, please close this.</pre>
<br />
<p>- Christoph</p>
<br />
<p>On July 4th, 2012, 12:47 p.m. UTC, Michael Skiba wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils and Evan Teran.</div>
<div>By Michael Skiba.</div>
<p style="color: grey;"><i>Updated July 4, 2012, 12:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Completing a JJ from KBO: Enable grouping of non-decimal numbers. I've added new options in the settings menu to allow the user to set individual grouping width.
KCalc now displays "11 1101 0110" in binary mode instead of "1111010110", the user can change that behavior to any value he or she wants for example bytewise: "11 11010110".
The user can set individual widths, which are stored for binary, octal and decimal. I've set the following defaults:
binary = 4 ['1110 1010']
octal = 4 ['5323 1356']
hexadecimal = 2 ['A2 F4 C2 11'] </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Save/Restoring of saved individual values work.
Calculation and conversation is correct.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=247151">247151</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>general.ui <span style="color: grey">(15bee34)</span></li>
<li>kcalc.kcfg <span style="color: grey">(6b613bd)</span></li>
<li>kcalcdisplay.h <span style="color: grey">(84c1908)</span></li>
<li>kcalcdisplay.cpp <span style="color: grey">(c1c238f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105427/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105427/s/614/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/03/kcalc_400x100.png" style="border: 1px black solid;" alt="Grouped binary number" /></a>
<a href="http://git.reviewboard.kde.org/r/105427/s/615/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/03/kcalc1_400x100.png" style="border: 1px black solid;" alt="Updated settings window" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>