<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103306/">http://git.reviewboard.kde.org/r/103306/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 10th, 2012, 1:18 a.m., <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please commit to the master branch.</pre>
</blockquote>
<p>On May 10th, 2012, 2:50 p.m., <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks you for committing.
For future reference: I saw that you committed this patch (4ede2c074e5f622edf8333892286296f2d4e9b8b) and the one for review request 103223 (50d645ad0a2ffa53e5d032aac52b3874e816ae67) without rebasing, which ended up creating 3 useless merge commits in master. And you also did not use the REVIEW keyword in the commit message to reference the review requests you made. This all makes going through Ark's history harder.
For your next patches, please check <http://techbase.kde.org/Policies/SVN_Commit_Policy#Special_keywords_in_SVN_log_messages> for how to use the REVIEW keyword in your commit messages and rebase your commits correctly on top of the current branch so these unnecessary merge commits are not created.
You now need to close your review requests manually.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Re-ping, please close this review request as Submitted.</pre>
<br />
<p>- Raphael</p>
<br />
<p>On May 9th, 2012, 12:13 p.m., Michal Sciubidlo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Michal Sciubidlo.</div>
<p style="color: grey;"><i>Updated May 9, 2012, 12:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add read support for cab archives. Libarchive from version 3.0.0 is going to support cab files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Witch libarchive 2.8.0 - cmake shows message "Your libarchive does not have support for cab archives. libarchive >= 3.0.0 is required for this."
Witch libarchive 3.0.1b - cmake don't show messages. Ark open, list and extract cab files.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=83136">83136</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/CMakeLists.txt <span style="color: grey">(99c9374)</span></li>
<li>plugins/libarchive/CMakeLists.txt <span style="color: grey">(6a255f8)</span></li>
<li>cmake/modules/FindLibArchive.cmake <span style="color: grey">(40bb40f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103306/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>