<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103496/">http://git.reviewboard.kde.org/r/103496/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 5th, 2012, 2:39 p.m., <b>Martin Tobias Holmedahl Sandsmark</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">have you measured memory usage?</pre>
</blockquote>
<p>On January 5th, 2012, 4:40 p.m., <b>Anssi Hannula</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On the same test filesystem with a 32-bit binary, the resident memory usage after a completed scan is 72-73 MB regardless of quint32 and quint64 (I also checked the output for overflows to make sure I didn't run a wrong version).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">applied in ae73232b03b18c7711204873e56b7d702b1a13f6, thanks again. :-D</pre>
<br />
<p>- Martin Tobias Holmedahl</p>
<br />
<p>On December 21st, 2011, 7:44 p.m., Anssi Hannula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Anssi Hannula.</div>
<p style="color: grey;"><i>Updated Dec. 21, 2011, 7:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Filelight uses a divide-by-1024 trick to fit sizes over 4 GB into a
quint32. However, the current code will wrap around again at 4 TB.
Simply switch to quint64 and drop the use of divide-by-1024 trick to get
rid of the 4 TB wrap-around.
The performance penalty on a 32-bit system seems immeasurable. On a
filesystem with 1500000 files (13 TB) the process user time is only 1..5
seconds on i7-960, with quint32/64 having no effect. Most of the
wallclock time (20..500 sec in the above case, depending on cache
state) is spent waiting for I/O anyway.
Note that on 32-bit systems files over 2 GB are still completely ignored
unless built with large file support.
Note that this patch is on top of https://reviewboard.kde.org/r/102870/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built git master with the patch, tested to fix wrap-around on both 64-bit and 32-bit systems, and checked briefly that performance didn't suffer as noted in the description.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/part/fileTree.h <span style="color: grey">(fe0a9ec)</span></li>
<li>src/part/fileTree.cpp <span style="color: grey">(6da7a8f)</span></li>
<li>src/part/localLister.cpp <span style="color: grey">(588a56a)</span></li>
<li>src/part/remoteLister.cpp <span style="color: grey">(139b7a7)</span></li>
<li>src/part/summaryWidget.cpp <span style="color: grey">(ebbc516)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103496/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>