<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103221/">http://git.reviewboard.kde.org/r/103221/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 23rd, 2011, 10:25 p.m., <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch as it stands ends up effectively disabling the preview dialog, which is a no-go -- calling KMimeTypeTrader::query() without specifying the service type will use "Application" as default and all files will be previewed externally (there is another bug for allowing a user to choose to view a file externally, but that's another issue).
The related bug is a tricky issue whose proper fix I still don't know -- see http://article.gmane.org/gmane.comp.kde.devel.core/59514</pre>
</blockquote>
<p>On November 24th, 2011, 10:28 a.m., <b>Michal Sciubidlo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why disabling preview dialog is no-go?
Now ark ignores kde and user settings. It's coincidence that kde default app is konqueror. When kde will change it as you suggested kde.devel.core ark will ignore it.</pre>
</blockquote>
<p>On November 24th, 2011, 12:21 p.m., <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Disabling it is a no-go because it works most of the time and is a nice feature to have. Ark does not ignore KDE and user settings: the code first looks for read-only parts capable of displaying the given mimetype (which is defined by the user in System Settings -> File Associations -> Embedding) and then for an application which can do that (System Settings -> File Associations -> General), so if KDE/the user changes settings, those will be automatically be picked up by Ark (I mean, KMimeTypeTrader).</pre>
</blockquote>
<p>On November 24th, 2011, 8:48 p.m., <b>Michal Sciubidlo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see where i was wrong. I still think that current solution is not good. There are others confused by this (two last comments in https://bugs.kde.org/show_bug.cgi?id=201162). Associations -> General are importand and Associations -> Embedding should be hidden (only for apps use or even deleted). IMO ideal solution would be using assoc->general list. If first element has read only part ark should use it. If it don't have it full app should be opened. Any later general associations and whole embedded list should be ingored.
Two lists, apps can pick from any of them... that is "evil".</pre>
</blockquote>
<p>On November 30th, 2011, 10:02 p.m., <b>Michal Sciubidlo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you think this solution will be ok or two lists are better and leave it?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure I understood your idea. Are you saying the naming in the File Associations dialog is bad and needs to be improved or are you suggesting more fundamental changes? The separation between applications which can only be launched and those which have a KPart that can be embedded in another program is part of what makes KDE be KDE, from what I see.</pre>
<br />
<p>- Raphael</p>
<br />
<p>On November 23rd, 2011, 7:13 p.m., Michal Sciubidlo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Michal Sciubidlo.</div>
<p style="color: grey;"><i>Updated Nov. 23, 2011, 7:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use user preferred application to preview files. For now user has to delete every read only kpart from list to use other application as defcault.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Set kate as default, rekonq as second. Result: file opened with kate.
Set rekonq as default, kate as second. Result: file opened with rekonq.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=201162">201162</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/arkviewer.cpp <span style="color: grey">(9bfd651)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103221/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>