<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123482/">https://git.reviewboard.kde.org/r/123482/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By James Smith.</div>
<p style="color: grey;"><i>Updated March 7, 2016, 6:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Notable changes:
1) The requestedAccountPresences() QMap is replaced with a KTp::Presence type that takes an account as an argument and returns the account presence, or a presence of unset type if there is no independent presence known for that account.
2) The PluginQueuePlugins typdef, and corresponding QProperties, which were read properties only, were removed. The queuePlugin properties are now QMaps.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">New classes:
-StatusHandlerPresence, an interface for StatusHandler PluginQueue and AccountStatusHelper DBus interfaces, and a number of control functions for the Presence / StatusMessageInserter plugins (per-app save / restore presence replacement).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">New properties:
-GlobalPresence: bool activeAutoPresence(), bool mixedPresenceMode(), KTp::Presence globalRequestedPresence().</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">New methods:
-GlobalPresence: onAccountDisabled(Tp::AccountPtr)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">New types:
KTp::PluginQueue, for indicating the state of the plugin queue plugins, e.g. PluginDisabledOnLoad, PluginDisabled, PluginEnabled, PluginActive, etc.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">New features:
-pluginQueue active / inactive information in GlobalPresence, separate presenceQueueActiveChanged and statusMessageQueueActiveChanged signals.
-More reliable account property signalling.
-Reworked account enable / disable.
-Presence priority improvements.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Other simple cleanups (Use KTp::Presence where possible, make function arguments conform, commenting clarifications, errant properties, etc.)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compile, run.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/CMakeLists.txt <span style="color: grey">(85d578bc3cbc0ae5769e6ff9f466381da4e701a7)</span></li>
<li>KTp/Declarative/qml-plugins.cpp <span style="color: grey">(4956a1c94fe60a526367f6a74a357d510e74e519)</span></li>
<li>KTp/Models/presence-model.cpp <span style="color: grey">(ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519)</span></li>
<li>KTp/global-presence.h <span style="color: grey">(46e6cc358b0f3cdaff35d3a7be25949646b400d3)</span></li>
<li>KTp/global-presence.cpp <span style="color: grey">(8f1148b4ec339ab77f9c2fca0c87429ac14c5194)</span></li>
<li>KTp/presence.h <span style="color: grey">(7da07d0120c75ed057f4b2f2f832f5a1f80bd528)</span></li>
<li>KTp/presence.cpp <span style="color: grey">(6030db0ed821a4399603b5453ab124c741912a1f)</span></li>
<li>KTp/status-handler-presence.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/status-handler-presence.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/types.h <span style="color: grey">(27eb8975a4149e78c1e545b7273572c7eb18bad3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123482/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>