<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126071/">https://git.reviewboard.kde.org/r/126071/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No one commented, it is a valid solution to the crashes. so I pushed. it</p></pre>
<br />
<p>- Diane Trout</p>
<br />
<p>On November 14th, 2015, 10:02 p.m. PST, Diane Trout wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Diane Trout.</div>
<p style="color: grey;"><i>Updated Nov. 14, 2015, 10:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-call-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">GStreamer reported warnings when trying to remove the sending bins
from the pipelines as they seem to be already unlinked when the
SinkManager::onPadUnlinked is called.
I discovered this by getting the source Element srcPad->parentElement()
and checking to see if that has a parent. After the bin is added to the
pipline it does have a parent, but by onPadRemoved it had been removed
from the pipeline.
I only tested audio calls which showed me that channelHandler()->pipeline()
could be null. I decided that that probably could happen to the video
path as well so added the guard condition there as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While trying to decide if this was a good idea I added quite a bit more logging messages which I removed before commiting. I did verify that the bin connecting the conference to the audio source really does seem to be being unlinked by GStreamer.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Or at least I couldn't find any place in the code here where it was unlinked.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libktpcall/private/sink-controllers.cpp <span style="color: grey">(bd3c54cfade315671e8445b371094e3c6d1511b7)</span></li>
<li>libktpcall/private/tf-audio-content-handler.cpp <span style="color: grey">(1dd797bfb1a53c52eb6a0c8a9671ee6a54551af2)</span></li>
<li>libktpcall/private/tf-channel-handler.cpp <span style="color: grey">(1a0a0dcc7afb390d4ed40fb57cbaece82ea3d3b5)</span></li>
<li>libktpcall/private/tf-video-content-handler.cpp <span style="color: grey">(0d2d1bf6176d3b04c489f332913de18ea8908661)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126071/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>