<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125780/">https://git.reviewboard.kde.org/r/125780/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 24th, 2015, 4:11 p.m. PDT, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">as his mentor for this code, +1 too</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">David, is there any chance you had conversation with the student saying about how he should use LGPL 2.1+?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also there's some other code in the KTp/OTR directory that was also done by the student that was licensed as GPL-2+. That's at least a valid license so can be redistributed, but it still might not be what was intended.</p></pre>
<br />
<p>- Diane</p>
<br />
<p>On October 24th, 2015, 11:59 a.m. PDT, Diane Trout wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Diane Trout.</div>
<p style="color: grey;"><i>Updated Oct. 24, 2015, 11:59 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Scott Kitterman noticed the license for this code was
"GPL 2.1+" which doesn't exist.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I (Diane Trout) tried to contact the author on a few occasions but
did not see a response.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I believe this code was created as a Google Summer of Code project and
so the following criteria which states that the student needs to choose
a license approved by the mentoring organization.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">http://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc2015/help_page?PageSpeed=noscript#2._What_licenses_do_I_have_to_choose</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The most likely thing is that the original license block is a
typo and the student had first written GPL-3, but then changed it to
GPL 2.1, but forgot to add the "Lesser".</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In an ideal world the student Marcin Ziemi?ski would approve this.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ran licensecheck -cr * | grep -v LGPL and made sure there was no GPL license still around.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>otr-proxy/KTpProxy/main.cpp <span style="color: grey">(87e1df6b20df098f75916e13837f38d5a00dfba7)</span></li>
<li>otr-proxy/KTpProxy/otr-config.h <span style="color: grey">(ce42c00cfb37774494888f722f6766288d45d78a)</span></li>
<li>otr-proxy/KTpProxy/otr-config.cpp <span style="color: grey">(28c316c4ef79be6b286121991477c86e34b14720)</span></li>
<li>otr-proxy/KTpProxy/otr-constants.h <span style="color: grey">(08f1a14f821583832e2e44e87449d241be7014f3)</span></li>
<li>otr-proxy/KTpProxy/otr-manager.h <span style="color: grey">(b8807aa6b61c94e968dc931a2188065fb3b972c3)</span></li>
<li>otr-proxy/KTpProxy/otr-manager.cpp <span style="color: grey">(6cbdfdffa48fbceb213140300d1b1ac684e2c57e)</span></li>
<li>otr-proxy/KTpProxy/otr-message.h <span style="color: grey">(cd46f07676934e6c425436c3a96060e30b70f77e)</span></li>
<li>otr-proxy/KTpProxy/otr-message.cpp <span style="color: grey">(d475f40c28d5d10ed4f20c9397dd8bb9afbd949f)</span></li>
<li>otr-proxy/KTpProxy/otr-proxy-channel-adaptee.h <span style="color: grey">(78fd81b73deb450b13dc559c439c3c39010ce9fa)</span></li>
<li>otr-proxy/KTpProxy/otr-proxy-channel-adaptee.cpp <span style="color: grey">(e30167f7512deaac50c7d3c136cfab496b5188b6)</span></li>
<li>otr-proxy/KTpProxy/otr-proxy-channel.h <span style="color: grey">(daefe67c24979bbc61ef5f15d462f9b48c674895)</span></li>
<li>otr-proxy/KTpProxy/otr-proxy-channel.cpp <span style="color: grey">(025bebc2f465717ee6d8610763801848356d6f59)</span></li>
<li>otr-proxy/KTpProxy/otr-session.h <span style="color: grey">(de1b3819d5dda1753000d3ceb96b7d17fbbca94f)</span></li>
<li>otr-proxy/KTpProxy/otr-session.cpp <span style="color: grey">(60c169f2661c56e6b5b737d8098d9354def643d8)</span></li>
<li>otr-proxy/KTpProxy/otr-utils.h <span style="color: grey">(fd80d146b324f674fef7be8b6c68f0bc4280a164)</span></li>
<li>otr-proxy/KTpProxy/otr-utils.cpp <span style="color: grey">(4b506221bfbdf8a46e3524fdba23d007ce5906fd)</span></li>
<li>otr-proxy/KTpProxy/pending-curry-operation.h <span style="color: grey">(80e3fcc009f66fe0eb5809c553bde669baa874d1)</span></li>
<li>otr-proxy/KTpProxy/pending-curry-operation.cpp <span style="color: grey">(f5eee49269fc885c0db7660db6e3f5774a833b62)</span></li>
<li>otr-proxy/KTpProxy/proxy-observer.h <span style="color: grey">(5b37e021ab2c2e11c044ab914985d28c3712f6c0)</span></li>
<li>otr-proxy/KTpProxy/proxy-observer.cpp <span style="color: grey">(f8c715d908f8c9bf2dde4dd477ce6dd32440dd00)</span></li>
<li>otr-proxy/KTpProxy/proxy-service-adaptee.h <span style="color: grey">(25b5e1e3e1b01ad976b40dded5e1a40393fabbce)</span></li>
<li>otr-proxy/KTpProxy/proxy-service-adaptee.cpp <span style="color: grey">(509349dc3fcb76519f0f945b33833c8b6c3fc422)</span></li>
<li>otr-proxy/KTpProxy/proxy-service.h <span style="color: grey">(31f5e58f17418d288f42aaa3d51ef91823c11fbe)</span></li>
<li>otr-proxy/KTpProxy/proxy-service.cpp <span style="color: grey">(b5e68b15025f4a6fd0b8cf17547c58ee326af949)</span></li>
<li>otr-proxy/KTpProxy/types.h <span style="color: grey">(deee1b6d30895b81ff197212d2f001a2336f6d87)</span></li>
<li>otr-proxy/test/otr-test.cpp <span style="color: grey">(5979e102632e0e23373f6ed654b8580ca1cf5b6d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125780/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>